Skip to content

Import analyzer ast with explicit show. - #4300

Merged
scheglov merged 2 commits into
dart-lang:mainfrom
scheglov:analyzer-import-show
Oct 19, 2026
Merged

scheglov merged 2 commits into
dart-lang:mainfrom
scheglov:analyzer-import-show

Conversation

@scheglov

Copy link
Copy Markdown
Contributor

@scheglov
scheglov requested review from sigurdm and szakarias October 15, 2026 19:27

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the imports from 'package:analyzer/dart/ast/ast.dart' in both 'lib/src/model/package_builder.dart' and 'lib/src/model/package_graph.dart' to use explicit 'show' combinators, importing only the necessary types. There are no review comments, and I have no additional feedback to provide.

@scheglov
scheglov requested a review from srawlins October 15, 2026 19:37
copybara-service Bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 16, 2026
Note: until dart-lang/dartdoc#4300 lands, we temporarily use `TopLevelVariable2`. Renaming would be an easy mechanical change later.

Top-level variables were parsed as a V1 `TopLevelVariableDeclaration`
containing a `VariableDeclarationList` shared with fields and local
variables, and passes recovered whether a variable is top-level by
inspecting its grandparent.

They are now canonical V2 nodes: a `TopLevelVariablesDeclaration`, one
declaration that owns the comment, metadata, modifiers, type, and
semicolon, and contains `TopLevelVariable`s, each with a name, an
initializer, and a precise `TopLevelVariableFragment?`. The group
exposes the `const`, `final`, or `var` modifier as tokens, as
`FormalParameter` does, without `isConst`, `isFinal`, or `isLate`
flags.

`TopLevelVariableDeclarationImpl` is now a V1-only projection.
`VariableDeclarationListImpl` and `VariableDeclarationImpl` are still
canonical for fields and local variables, so they are canonical nodes
or projections of the V2 top-level variables, depending on how they
are created. `TopLevelVariableImpl` implements `VariableBindingImpl`,
so initializer resolution, top-level inference, and constant
evaluation are shared with fields and locals.
`visitTopLevelVariableDeclaration` is removed from the V2 visitors and
`addTopLevelVariableDeclaration` from `RuleVisitorRegistry2`; the V1
`RuleVisitorRegistry.addTopLevelVariableDeclaration` remains.

Bug: #64004
Change-Id: I962e1a75b8feed28f24df5ca796362d0f282458f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/564703
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
@scheglov
scheglov merged commit c0e19cf into dart-lang:main Oct 19, 2026
19 checks passed
copybara-service Bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 20, 2026
…, web

Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/4d80610..72e71ca):
  72e71ca0  Mon Oct 19 21:57:11 2026 +0200  Jonas Finnemann Jensen  Optimize `HashSink` and `_MD5Sink.updateHash` (RFC impl) (dart-lang/core#1013)

dartdoc (https://github.com/dart-lang/dartdoc/compare/e1859cf..c0e19cf):
  c0e19cf6  Mon Oct 19 11:41:42 2026 -0700  Konstantin Scheglov  Import analyzer ast with explicit show. (dart-lang/dartdoc#4300)

ecosystem (https://github.com/dart-lang/ecosystem/compare/622ef61..0ab0cfd):
  0ab0cfd  Mon Oct 19 15:44:26 2026 +0200  Moritz  fix(firehose): bump dependency_validator to support analyzer 14 (dart-lang/ecosystem#453)
  44a0768  Wed Oct 14 09:37:29 2026 -0700  Nate Bosch  Improve firehose publish validation log output (dart-lang/ecosystem#468)

http (https://github.com/dart-lang/http/compare/7d7aae2..a8a24a0):
  a8a24a0  Mon Oct 19 13:31:34 2026 -0700  Kevin Moore  docs(web_socket): remove non-user-visible changelog entry (dart-lang/http#2023)
  6f6ac5f  Mon Oct 19 16:29:43 2026 -0400  Mouad Debbar  [http_multi_server] Retry `loopback(0)` when IPv6 port is already bound (dart-lang/http#2025)
  6e91ce3  Tue Oct 13 16:25:39 2026 -0700  Kevin Moore  Sync root README.md package table from pubspec.yaml files (dart-lang/http#2024)

native (https://github.com/dart-lang/native/compare/cc7e4b0..3cbe319):
  3cbe319e3  Tue Oct 13 15:47:18 2026 +0200  Daco Harkes  [hooks_runner] Fail eagerly when file locking is not supported on file system (dart-lang/native#3679)

shelf (https://github.com/dart-lang/shelf/compare/b2cb503..b66665b):
  b66665b  Fri Oct 16 15:12:05 2026 -0700  Kevin Moore  chore: add health workflow and prepare shelf 1.4.3, shelf_router 1.1.5, and shelf_static 1.2.0 (dart-lang/shelf#546)

test (https://github.com/dart-lang/test/compare/9bf69a8..d1afeb1):
  d1afeb14  Fri Oct 16 20:41:51 2026 -0400  Mouad Debbar  Confirmation that `tearDown` is called on timeout (dart-lang/test#2798)
  3f6c2f14  Thu Oct 15 18:21:35 2026 -0700  Jacob MacDonald  Enable asserts in the cli compiler (dart-lang/test#2795)

tools (https://github.com/dart-lang/tools/compare/c1471db..f6c7a2d):
  f6c7a2d62  Mon Oct 19 07:59:24 2026 -0700  Kevin Moore  [pubspec_parse] Preserve input maps and YamlMap source spans (dart-lang/tools#2653)
  f1a55d953  Mon Oct 19 07:53:51 2026 -0700  Kevin Moore  [yaml] Fix tag URI decoding, numeric tag RangeErrors, and dead checks (dart-lang/tools#2630)
  340ded284  Mon Oct 19 07:43:31 2026 -0700  Kevin Moore  [unified_analytics] Prepare for 8.2.0 release (dart-lang/tools#2689)
  a73703543  Fri Oct 16 11:55:03 2026 -0700  Kevin Moore  [unified_analytics] Bump version to 8.2.0-wip (dart-lang/tools#2688)

web (https://github.com/dart-lang/web/compare/63e6662..4e60e61):
  4e60e61  Mon Oct 19 10:02:22 2026 -0700  dependabot[bot]  Bump source-map-js from 1.2.1 to 1.2.2 in /web_generator (dart-lang/web#591)
  7d63637  Mon Oct 19 09:50:26 2026 -0700  Kevin Moore  Add an api.txt golden for package:web (dart-lang/web#590)

[email protected]

Change-Id: Ibe6ac8a8246a27caa8a4846ea1acc78c801ee2ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/566781
Commit-Queue: Nate Bosch <[email protected]>
Reviewed-by: Brian Quinlan <[email protected]>
sgrekhov pushed a commit to sgrekhov/dartdoc that referenced this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants