Repository navigation
fix: resolve search icon contrast in dark mode - #4196
Merged
Merged
Conversation
guidezpl
approved these changes
Feb 13, 2026
Contributor
Author
|
@guidezpl give me a an hour and i will fix these ci/cd issues |
NamanGoyalK
force-pushed
the
fix/search-icon-dark-mode
branch
from
February 13, 2026 10:42
7dc7817 to
819fe50
Compare
Contributor
Author
Member
|
Cool beans, @NamanGoyalK ! No worries about the force push. It's not a HUGE deal, just something to be careful about. |
Contributor
Author
Contributor
Author
|
All checks are passing now! @guidezpl whenever you have a moment, this should be ready for a final review and merge. Thanks! |
guidezpl
approved these changes
Feb 15, 2026
Contributor
Author
Member
srawlins
approved these changes
Feb 16, 2026
srawlins
left a comment
srawlins
left a comment
Member
There was a problem hiding this comment.
LGTM, but please wait for @szakarias or @sigurdm or @jonasfj
Also CC @parlough who worked on this in the past, I believe.
szakarias
approved these changes
Feb 24, 2026
Adds search_dark.svg and updates theme variables to ensure visibility on dark backgrounds. Fixes dart-lang#4124.
szakarias
force-pushed
the
fix/search-icon-dark-mode
branch
from
February 24, 2026 13:46
eb06c26 to
ff1d4d9
Compare
Collaborator
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the accessibility issue where the search icon was nearly invisible in dark mode.
Changes:
lib/resources/search_dark.svgwith high contrast for dark backgrounds.--search-icon-urlinweb/styles/_theme.scssto handle theme-aware icon switching.web/styles/_search.scssto utilize the new variable.lib/src/generator/html_resources.g.dartand compiled assets to include the new resource in the build.Related Issues
Fixes #4124
Checklist
dart formaton all modified Dart files.before:
after:
