-
Notifications
You must be signed in to change notification settings - Fork 133
bumped analyzer version to 4.0.0 #3033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
|
@srawlins Thank you for approving this PR! I also noticed that running grinder build won't run out of the box. It seems that the Is there anything obvious I'm missing here to get this thing merged? |
|
I'll try bumping the file on my end, but you might just try |
|
@michaelgobbers - I sent you a PR against this PR: michaelgobbers#1. It regenerates the files - not sure if that address all the failures or not. |
Regenerate files
|
@devoncarew Seems like your PR did fix a few things. Still not fully there yet though... |
|
Thanks for the help, @michaelgobbers. Would you mind bumping the minimum version here to |
|
I might also just try my own PR because that CI failure is pretty... weird. |
|
@srawlins I did the version bump, just need the workflow approval. |
|
No idea what the continuing error is. I will investigate. |
|
I suspect a bug in analyzer. dart-lang/sdk#49225 |
|
@michaelgobbers sorry for the delay; we have a new analyzer release, 4.2.0. Would you mind setting that as the version to use? We can give this another try. |
|
@srawlins bumped to 4.2.0 |
|
Thanks so much! The CI issues are for deprecations in analyzer 4.2.0, and I'll just handle them in a follow-up PR. |
No description provided.