Skip to content

Conversation

@michaelgobbers
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented May 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@simolus3 simolus3 mentioned this pull request May 15, 2022
@michaelgobbers
Copy link
Contributor Author

@srawlins Thank you for approving this PR!
However, it seems CI is failing, I've been looking in to logs and it's telling me to run grind build because lib/src/generator/templates.runtime_renderers.dart needs to be regenerated. However when I do so it seems like it isn't regenerated.

I also noticed that running grinder build won't run out of the box. It seems that the compile js step has a wrongly formatted output option.

Is there anything obvious I'm missing here to get this thing merged?

@srawlins
Copy link
Member

I'll try bumping the file on my end, but you might just try dart run build_runner build instead of the grinder command. I think I do not run the grinder command.

@devoncarew
Copy link
Contributor

@michaelgobbers - I sent you a PR against this PR: michaelgobbers#1. It regenerates the files - not sure if that address all the failures or not.

@michaelgobbers
Copy link
Contributor Author

@devoncarew Seems like your PR did fix a few things. Still not fully there yet though...

@srawlins
Copy link
Member

srawlins commented Jun 8, 2022

Thanks for the help, @michaelgobbers. Would you mind bumping the minimum version here to ^4.1.0? That might fix the CI issue.

@srawlins
Copy link
Member

srawlins commented Jun 8, 2022

I might also just try my own PR because that CI failure is pretty... weird.

@michaelgobbers
Copy link
Contributor Author

@srawlins I did the version bump, just need the workflow approval.

@srawlins
Copy link
Member

srawlins commented Jun 9, 2022

No idea what the continuing error is. I will investigate.

@srawlins
Copy link
Member

srawlins commented Jun 9, 2022

I suspect a bug in analyzer. dart-lang/sdk#49225

@srawlins
Copy link
Member

@michaelgobbers sorry for the delay; we have a new analyzer release, 4.2.0. Would you mind setting that as the version to use? We can give this another try.

@michaelgobbers
Copy link
Contributor Author

@srawlins bumped to 4.2.0

@srawlins
Copy link
Member

srawlins commented Jul 5, 2022

Thanks so much! The CI issues are for deprecations in analyzer 4.2.0, and I'll just handle them in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants