Skip to content

Macros don't expand dartdoc directives injected by tools #1945

New issue
New issue
Closed
#2274
flutter/flutter
#63111
Closed
Macros don't expand dartdoc directives injected by tools#1945
#2274
flutter/flutter
#63111
Assignees
srawlins
Labels
P2A bug or feature request we're likely to work on

Description

@gspencergoog
gspencergoog
opened on Mar 25, 2019

In this page , there are {@inject-html} tags still present in the output. These examples are generated by the snippets tool, but they are part of a template, and it's not happening elsewhere, so I assume that this is because templates don't get a second pass when they are instantiated to expand dartdoc directives.

Related to flutter/flutter#29919

Activity

  1. jcollins-g
    added
    P2A bug or feature request we're likely to work on
    on Sep 30, 2019
  2. srawlins
    self-assigned this
    on Jul 23, 2020
  3. srawlins
    added a commit that references this issue on Jul 24, 2020

    Process directives after macro-processing; fixes dart-lang#1945

    5e7e912
  4. srawlins
    closed this as completedin #2274on Jul 24, 2020

  5. srawlins commented on Jul 30, 2020

    @srawlins
    srawlins
    on Jul 30, 2020
    Member

    Should be fixed with a bump to dartdoc 0.32.3, which I have not released yet.

  6. srawlins
    reopened this on Jul 30, 2020
  7. srawlins
    closed this as completedon Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2A bug or feature request we're likely to work on

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions