Repository navigation
Make Result sealed and subclasses final - #970
Conversation
These were never intended for extension and marking them `final` makes it easier to expand the API without breaking changes.
PR HealthUnused Dependencies ✔️
For details on how to fix these, see dependency_validator. This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with
Coverage
|
| File | Coverage |
|---|---|
| pkgs/async/lib/async.dart | 💔 Not covered |
| pkgs/async/lib/src/result/error.dart | 💚 88 % |
| pkgs/async/lib/src/result/result.dart | 💚 84 % |
| pkgs/async/lib/src/result/value.dart | 💚 80 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/collection/benchmark/legacy_quicksort.dart |
This check can be disabled by tagging the PR with skip-license-check.
|
This passed an internal test run, I think it's worth landing. |
natebosch
changed the title
Result and subclasses finalResult sealed and subclasses final
These were never intended for extension and marking them
finalmakesit easier to expand the API without breaking changes.
Resultassealed class.ValueResultandErrorResultasfinal class.Result,ValueResult, andErrorResultinto a singlelibrary using
partandpart ofto allow inheritance within thelibrary.
error.dartandvalue.dartfromlib/async.dart.