Repository navigation
Remove dart:mirrors from package:collection test/wrapper_test.dart - #1027
Conversation
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with Unused Dependencies ✔️
For details on how to fix these, see dependency_validator. This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
| test('delegates to underlying list', () { | ||
| var base = <int>[1, 2, 3]; | ||
| var wrapper = DelegatingList<int>(base); | ||
|
|
There was a problem hiding this comment.
Not testing Iterable members.
Consider moving the iterable testing into a helper function that takes an iterable and a list of expected valeus, and call it both from the DelegatingIterable test and from the delegating set and list tests. (And maybe for .keys and .values of a DelegatingMap.
There was a problem hiding this comment.
Followed up in #1028, sharing generic testIterable and testReadOnlySet helpers across DelegatingIterable, DelegatingList, DelegatingSet, DelegatingQueue, DelegatingMap (.keys/.values), MapKeySet, and MapValueSet.
…#169) Hardens the Dart code-review rubric against primary-constructor false positives and reflection/test-refactor blind spots, locks Deep-review and cold-read subagents to read-only file access, and keeps standalone personal fork worktrees anchored on `origin`. - **Dart 3.14+ & test-refactor rubric coverage**: Stamps primary-constructor dismissal guidance in `skills/pr-review/RUBRIC.md` and adds checks for `dart:mirrors` -> `package:analyzer` drift-test migrations ([google/protobuf.dart#1104](google/protobuf.dart#1104)), wrapper subtype contract helpers ([dart-lang/core#1027](dart-lang/core#1027)), `flutter test --platform=chrome` entrypoint bundling vs. `@TestOn('vm')`, and `setUp` fixture variable shadowing ([dart-lang/shelf#547](dart-lang/shelf#547)). - **Strict read-only subagents**: Requires tool-restricted read-only subagents with no shell execution in `skills/pr-review/SKILL.md` (`Review Mode: Deep`) and `skills/cold-read/SKILL.md` so subagents never re-run `dart test`, poll tasks, or shell out to `python3`/`wc`. - **Personal fork base-branch resolution**: Updates `skills/new-worktree/SKILL.md` to prefer `origin` on standalone `~/github/<owner>/<repo>` checkouts (unless `remote.upstream.gh-resolved` is `base`) while preserving `upstream` preference on `~/github/<repo>` contribution checkouts.
Removes the dart:mirrors dependency from wrapper_test.dart and replaces the reflection-based assertions with explicit behavioral tests. Also removes the @teston('vm') restriction, allowing the wrapper tests to run on Chrome/Wasm as well.