Repository navigation
disable the screenshots tool by default - #210
Merged
Merged
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
| static const _inspectorServiceExtensionPrefix = 'ext.flutter.inspector'; | ||
|
|
||
| /// Whether or not to enable the screenshot tool. | ||
| bool get enableScreenshots; |
Contributor
There was a problem hiding this comment.
should this default to false instead of being an abstract getter?
Contributor
Author
There was a problem hiding this comment.
This is overridden always so the default would be meaningless here
kenzieschmoll
approved these changes
Jun 30, 2025
kenzieschmoll
left a comment
kenzieschmoll
left a comment
Contributor
There was a problem hiding this comment.
a couple comments but lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling due to flutter/flutter#170357 - this only works today by default on the desktop environment.
We could fall back on full device screenshots but are holding off on that for now as we have to evaluate some extra potential privacy concerns with exposing the entire screen as opposed to just the flutter drawn pixels.