This repository was archived by the owner on Jan 28, 2024. It is now read-only.
Run Flutter FFI plugin template ffigen on CI #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test currently fails because is not in Flutter yet. |
dcharkes
added a commit
to flutter/flutter
that referenced
this pull request
Aug 2, 2022
Closes: * #105513 Will add a regression test on the FFIgen repo after merge: * dart-archive/ffigen#433
This was referenced Aug 2, 2022
Contributor
Author
|
@liamappelbe PTAL |
liamappelbe
approved these changes
Aug 5, 2022
Contributor
liamappelbe
left a comment
liamappelbe
left a comment
There was a problem hiding this comment.
Approved with comments.
test_flutter/flutter_template_tests/flutter_plugin_ffi_test.dart
Outdated
Show resolved
Hide resolved
| final bindingsGeneratedCopyUri = | ||
| libDirUri.resolve('${projectName}_bindings_generated_copy.dart'); | ||
|
|
||
| await Task.serial([ |
Contributor
There was a problem hiding this comment.
All this Task stuff seems like a lot of boilerplate. Why not just write a runProcess and copyFile function, and do:
await runProcess(...);
await copyFile(...);
await runProcess(...);
Contributor
Author
There was a problem hiding this comment.
I had this laying around in another project. I can simplify it for this test if you prefer.
Contributor
There was a problem hiding this comment.
Feel free to merge as-is if you're too busy to clean it up. It's only a test after all. I've already approved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test for: