Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

ScopedOutput fixes - #267

Merged
grouma merged 1 commit into
masterfrom
small-fixes
Aug 14, 2019
Merged

grouma merged 1 commit into
masterfrom
small-fixes

Conversation

@grouma

@grouma grouma commented Aug 13, 2019

Copy link
Copy Markdown
Contributor

Document scopedOutput argument and also default the value.

Although we default scopedOutput where it matters I've decided to also default it within collect() to prevent any accidental future issues.

Closes dart-lang/tools#454

@grouma
grouma requested a review from cbracken August 13, 2019 18:27

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grouma
grouma merged commit fb34a7d into master Aug 14, 2019
@grouma
grouma deleted the small-fixes branch August 14, 2019 16:22
@cbracken cbracken mentioned this pull request Sep 27, 2019
mosuem pushed a commit to dart-lang/tools that referenced this pull request Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Some documentation needed: coverage()

2 participants