Fix trigger export with duplicate FOR EACH clause when a REFERENCING clause is present. Thanks to Carens Kurniawan Wijaya for the report.

darold · darold · commit fb6b0ad54725 · 2024-02-17T22:23:59.000+01:00
diff --git a/lib/Ora2Pg.pm b/lib/Ora2Pg.pm
@@ -5806,9 +5806,9 @@ sub export_trigger
 					$reftb =~ s/NEW TABLE AS Inserted // if ($trig->[2] eq 'DELETE');
 					$sql_output .= "$reftb FOR EACH STATEMENT\n";
 				} elsif ($statement) {
-					$sql_output .= "FOR EACH STATEMENT\n";
+					$sql_output .= "FOR EACH STATEMENT\n" if ($sql_output !~ /FOR EACH STATEMENT/);
 				} else {
-					$sql_output .= "FOR EACH ROW\n";
+					$sql_output .= "FOR EACH ROW\n" if ($sql_output !~ /FOR EACH ROW/);
 				}
 				$sql_output .= "\tEXECUTE PROCEDURE $trig_fctname();\n\n";
 			}

Original file line number	Diff line number	Diff line change
`@@ -5806,9 +5806,9 @@ sub export_trigger`
`5806`	`5806`	`$reftb =~ s/NEW TABLE AS Inserted // if ($trig->[2] eq 'DELETE');`
`5807`	`5807`	`$sql_output .= "$reftb FOR EACH STATEMENT\n";`
`5808`	`5808`	`} elsif ($statement) {`
`5809`		`- $sql_output .= "FOR EACH STATEMENT\n";`
	`5809`	`+ $sql_output .= "FOR EACH STATEMENT\n" if ($sql_output !~ /FOR EACH STATEMENT/);`
`5810`	`5810`	`} else {`
`5811`		`- $sql_output .= "FOR EACH ROW\n";`
	`5811`	`+ $sql_output .= "FOR EACH ROW\n" if ($sql_output !~ /FOR EACH ROW/);`
`5812`	`5812`	`}`
`5813`	`5813`	`$sql_output .= "\tEXECUTE PROCEDURE $trig_fctname();\n\n";`
`5814`	`5814`	`}`