Conversation
|
@Christian-Kr : Just a note that we are in the process of releasing the 4.6 release. So your work will be reviewed a bit later. Nice to see some work toward Gtk4, do you have a clear view of the amount of work needed? TIA. |
|
Hello @TurboGit, don't worry. I had a clear view for other applications, but for darktable, I just wanted to start coding. So no, I don't know the amount of work. Greetings |
|
Could we maybe have a new label we can use for Gtk4 preparatory work. Even better if we could have an issue to track some sort of to-do list, so others can assist with the work. There will almost certainly be some more complicated bits of functionality to change so separate issues for those would be good as well (as-and-when you find that sort of thing). |
ghost
mentioned this pull request
|
|
This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
|
Reopen with conflict resolved and rebase. |
ghost
reopened this
|
This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
|
Hello to everyone, how do we want to go on with this small one? Do we want to pull it to master or to another branch or cancel it totally? I am just asking because I want to clean few things up. Thx in advance :-) |
|
In order to make the whole migration inside a single branch, close this one and merge the branch Christian-Kr:krippendorf/gtk4_prepare_002 into Christian-Kr:krippendorf/gtk4. This PR is not needed anymore. Greetings |
ghost
closed this
2 participants
Hello to everyone,
as part of the migration to gtk4 remove the method gtk_widget_set_app_paintable. The gtk3 documentation says, that most widgets already ignore this setting and it is only helpful if you want to change the background of some widgets.
After testing the change, I can't see any widget background that might have changed. Maybe it has already been changed, or I just missed a change.
Please test the change and if everything is still working, accept the PR.
Thank you in advance.
Greetings