Fix: TabBar Changes delayed (1s) when scrolling#166
Merged
Leonavichus merged 2 commits intodarkmoonight:mainfrom Feb 10, 2024
Merged
Fix: TabBar Changes delayed (1s) when scrolling#166Leonavichus merged 2 commits intodarkmoonight:mainfrom
Leonavichus merged 2 commits intodarkmoonight:mainfrom
Conversation
Member
|
Thank you so much for contributing to the development of the app! |
Contributor
Author
|
Thank you so much for integrating this feature into the one and only Rain app (by far the best weather app)! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @Leonavichus ,
I love this app and would like to help improving it.
One thing that triggers me every time: When I scroll between the three tabs (WeatherPage, ListWeatherCard, SettingsPage) it takes ages for the TabBar to show the selected tabIndex.
I found this StackOverflow question: https://stackoverflow.com/questions/57948157/tabcontroller-does-not-change-when-scrolling-the-screenlike-its-waiting-1-sec. I think this is the way we can solve this issue...
I have implemented the basics but not tested it, because I don't have SDKs and everything set up. There are probably many other things which need to be changed in order for this to work...
Nevertheless, it would be a great honor for me if you test these changes and we maybe see them in the next release...
Looking forward for your reply 😊