use src map if dst is nil and can't be set#177
Merged
darccio merged 1 commit intodarccio:masterfrom Mar 3, 2021
Merged
Conversation
|
Hello, @ndeloof! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
|
SourceLevel has finished reviewing this Pull Request and has found:
|
see darccio#90 Signed-off-by: Nicolas De Loof <[email protected]>
|
Hello @imdario! Thanks! |
darccio
approved these changes
Mar 3, 2021
Owner
|
@ulyssessouza Done. Thanks @ndeloof! |
This was referenced Mar 10, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a struct field of type
mapis processed, and was not initialized as non-nil, don't try to set with a fresh new map and just adopt src value.As I'm not sure about the potential side-effects, I've kept the original logic for cases where dst can be set.
fix #90
related: