Skip to content

Chore: new rc#1161

Merged
alicejgibbons merged 1 commit into
dapr:release-1.15from
alicejgibbons:alicejgibbons/new-rc
Feb 13, 2025
Merged

Chore: new rc#1161
alicejgibbons merged 1 commit into
dapr:release-1.15from
alicejgibbons:alicejgibbons/new-rc

Conversation

@alicejgibbons

@alicejgibbons alicejgibbons commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

Description

Fix python failing tests

Issue reference

#1143

Please reference the issue this PR will close: #1143

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Alice Gibbons <[email protected]>
@alicejgibbons
alicejgibbons requested review from a team as code owners February 7, 2025 19:43
rochabr

This comment was marked as outdated.

@rochabr
rochabr self-requested a review February 8, 2025 07:24

@rochabr rochabr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but the tests are still failing. it doesn't look related to the previous bug, though. can we check?

@alicejgibbons
alicejgibbons marked this pull request as draft February 10, 2025 13:37

@msfussell msfussell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alicejgibbons
alicejgibbons marked this pull request as ready for review February 13, 2025 12:20
@alicejgibbons
alicejgibbons merged commit e46a35f into dapr:release-1.15 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants