Skip to content

Standardize readme shield badges#1147

Merged
msfussell merged 1 commit into
dapr:masterfrom
MO2k4:adjust-readme
Feb 3, 2025
Merged

Standardize readme shield badges#1147
msfussell merged 1 commit into
dapr:masterfrom
MO2k4:adjust-readme

Conversation

@MO2k4

@MO2k4 MO2k4 commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

Description

Standardize readme shield badges

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1023

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@MO2k4
MO2k4 requested review from a team as code owners January 24, 2025 13:27
@marcduiker

marcduiker commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

@MO2k4 thanks for picking this up again
Could you sign off your commit? See the DCO check for more info.

@MO2k4

MO2k4 commented Jan 30, 2025

Copy link
Copy Markdown
Contributor Author

@marcduiker done

@marcduiker

marcduiker commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

Thank you @MO2k4!

@dapr/approvers-quickstarts this is only a change in the README, validation workflows can be skipped on this PR.

@alicejgibbons

alicejgibbons commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

LGTM, can be merged.

msfussell
msfussell approved these changes Feb 3, 2025
View reviewed changes

@msfussell msfussell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msfussell
msfussell merged commit 8cf6d32 into dapr:master Feb 3, 2025
@marcduiker

marcduiker commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

@holopin-bot @MO2k4 Thank you! Here's a digital badge as a small token of appreciation.

@holopin-bot

holopin-bot Bot commented Jun 11, 2025

Copy link
Copy Markdown

Congratulations @MO2k4, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs2npnq166607i9iqlnjnpk

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msfussell msfussell msfussell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Standardize README shield badges

4 participants

@MO2k4 @marcduiker @alicejgibbons @msfussell