Skip to content

Cherry picking 42a99c2 into release branch#1135

Merged
paulyuk merged 2 commits into
dapr:release-1.15from
alicejgibbons:release-1.15
Jan 22, 2025
Merged

Cherry picking 42a99c2 into release branch#1135
paulyuk merged 2 commits into
dapr:release-1.15from
alicejgibbons:release-1.15

Conversation

@alicejgibbons

@alicejgibbons alicejgibbons commented Jan 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Cherry picking the python sdk crypto quickstart into the 1.15 release branch.

Issue reference

PR: #1093
Issue for master: #1052

Please reference the issue this PR will close: #1052

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@alicejgibbons
alicejgibbons requested review from a team as code owners January 18, 2025 17:43
@msfussell msfussell mentioned this pull request Jan 20, 2025
Closed
paulyuk
paulyuk requested changes Jan 20, 2025
View reviewed changes

@paulyuk paulyuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please have one clean PR for Jobs (this one?) and one for Crypto in Python? Sorry for extra work but this keeps the churn down and helps us protect the tests.

Comment thread cryptography/python/sdk/README.md
Comment thread cryptography/python/sdk/crypto-quickstart/desert.jpg
@paulyuk

paulyuk commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Also let me know if you need help getting tests to pass again in this branch. I think it's pointing to unexpected deprecation warnings.

@alicejgibbons alicejgibbons changed the title Dotnet HTTP Jobs Quickstart Cherry picking 42a99c2 into release branch Jan 20, 2025
@KentHsu @alicejgibbons
add python-sdk in cryptography (#1093)
46658b1 
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: Alice Gibbons <[email protected]>
@alicejgibbons alicejgibbons mentioned this pull request Jan 20, 2025
Closed
4 tasks
rochabr
rochabr reviewed Jan 21, 2025
View reviewed changes
Comment thread cryptography/python/sdk/README.md
rochabr
rochabr requested changes Jan 21, 2025
View reviewed changes

@rochabr rochabr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verbiage changes

Comment thread cryptography/python/sdk/README.md
@alicejgibbons

alicejgibbons commented Jan 21, 2025

Copy link
Copy Markdown
Contributor Author

Resolved the comments for the python sdk crypto quickstart since this has already been merged in #1093 to master. This just needs to be merged into 1.15 release branch

@alicejgibbons
alicejgibbons requested a review from paulyuk January 21, 2025 18:14
@mikeee mikeee mentioned this pull request Jan 22, 2025
Merged
4 tasks
@paulyuk
paulyuk merged commit 8d2c7ab into dapr:release-1.15 Jan 22, 2025
@marcduiker

marcduiker commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

@holopin-bot @alicejgibbons Thank you! Here's a digital badge as a small token of appreciation.

@holopin-bot

holopin-bot Bot commented Jun 11, 2025

Copy link
Copy Markdown

Congratulations @alicejgibbons, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs1fcf3047007l737fyhxq1

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rochabr rochabr rochabr requested changes
@mikeee mikeee mikeee approved these changes
@paulyuk paulyuk Awaiting requested review from paulyuk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alicejgibbons @paulyuk @marcduiker @rochabr @mikeee @KentHsu