Skip to content

Workflow: remove sleeps from example#894

Merged
acroca merged 2 commits into
dapr:mainfrom
JoshVanL:example-workflow-remove-sleeps
Jan 19, 2026
Merged

Workflow: remove sleeps from example#894
acroca merged 2 commits into
dapr:mainfrom
JoshVanL:example-workflow-remove-sleeps

Conversation

@JoshVanL

Copy link
Copy Markdown
Contributor

Remove arbitrary sleeps from workflow examples

Remove arbitrary sleeps from workflow examples

Signed-off-by: joshvanl <[email protected]>
@JoshVanL
JoshVanL requested review from a team as code owners January 16, 2026 19:31
@cicoyle cicoyle added this to the v1.17 milestone Jan 16, 2026
@CasperGN

Copy link
Copy Markdown
Contributor

@JoshVanL can you run tox -e ruff or just ruff locally to fix the formatting?

Signed-off-by: joshvanl <[email protected]>
@JoshVanL

Copy link
Copy Markdown
Contributor Author

@CasperGN done

@codecov

codecov Bot commented Jan 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.95%. Comparing base (bffb749) to head (97a59ad).
⚠️ Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
+ Coverage   86.63%   86.95%   +0.32%     
==========================================
  Files          84      103      +19     
  Lines        4473     6900    +2427     
==========================================
+ Hits         3875     6000    +2125     
- Misses        598      900     +302     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acroca
acroca added this pull request to the merge queue Jan 19, 2026
Merged via the queue into dapr:main with commit de3eef6 Jan 19, 2026
13 checks passed
sicoyle pushed a commit to sicoyle/python-sdk that referenced this pull request Mar 5, 2026
* Workflow: remove sleeps from example

Remove arbitrary sleeps from workflow examples

Signed-off-by: joshvanl <[email protected]>

* tox -e ruff

Signed-off-by: joshvanl <[email protected]>

---------

Signed-off-by: joshvanl <[email protected]>
sicoyle pushed a commit to sicoyle/python-sdk that referenced this pull request Mar 5, 2026
* Workflow: remove sleeps from example

Remove arbitrary sleeps from workflow examples

Signed-off-by: joshvanl <[email protected]>

* tox -e ruff

Signed-off-by: joshvanl <[email protected]>

---------

Signed-off-by: joshvanl <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
sicoyle added a commit that referenced this pull request Mar 6, 2026
* Workflow: remove sleeps from example (#894)

* Workflow: remove sleeps from example

Remove arbitrary sleeps from workflow examples

Signed-off-by: joshvanl <[email protected]>

* tox -e ruff

Signed-off-by: joshvanl <[email protected]>

---------

Signed-off-by: joshvanl <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>

* Workflow versioning (#893)

Signed-off-by: Albert Callarisa <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>

* fix: signal when dt reader stream is ready within wf client start call (#901)

* fix: signal when dt reader stream is ready within wf client start call

Signed-off-by: Samantha Coyle <[email protected]>

* style: appease linter

Signed-off-by: Samantha Coyle <[email protected]>

* fix: enable configurability + lint fixes

Signed-off-by: Samantha Coyle <[email protected]>

* fix(build): add tests and fix bug

Signed-off-by: Samantha Coyle <[email protected]>

* fix(build): add more tests

Signed-off-by: Samantha Coyle <[email protected]>

* style: appease linter

Signed-off-by: Samantha Coyle <[email protected]>

* fix(build): add another test

Signed-off-by: Samantha Coyle <[email protected]>

* test: add even more tests for build to pass lol

Signed-off-by: Samantha Coyle <[email protected]>

---------

Signed-off-by: Samantha Coyle <[email protected]>

* feat(convo): add new fields to conversation api (#902)

* feat(convo): add new fields to conversation api

Signed-off-by: Samantha Coyle <[email protected]>

* fix: update proto/grpc code generator and add more tests

Signed-off-by: Samantha Coyle <[email protected]>

* style: appease linter

Signed-off-by: Samantha Coyle <[email protected]>

* style: tox -e type fixes

Signed-off-by: Samantha Coyle <[email protected]>

---------

Signed-off-by: Samantha Coyle <[email protected]>

* add venv (#921)

Signed-off-by: Cassandra Coyle <[email protected]>
Co-authored-by: Sam <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>

* fix: Align Workflow Multi App Naming Convention (#932)

Signed-off-by: Matheus André <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>

* fix(bug): workflow client missing close function to pass to durable task (#889)

* chore(deps): bump dapr dep to 1.17.0.dev

Signed-off-by: Casper Nielsen <[email protected]>

* chore(deps): bump durabletask-dapr to 0.2.0a15

Signed-off-by: Casper Nielsen <[email protected]>

* feat: ensure taskhubgrpcclient expose .close() method for clients to pass down a close call to durabletask

Signed-off-by: Casper Nielsen <[email protected]>

---------

Signed-off-by: Casper Nielsen <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>

* fix: signal when dt reader stream is ready within wf client start call (#901)

* fix: signal when dt reader stream is ready within wf client start call

Signed-off-by: Samantha Coyle <[email protected]>

* style: appease linter

Signed-off-by: Samantha Coyle <[email protected]>

* fix: enable configurability + lint fixes

Signed-off-by: Samantha Coyle <[email protected]>

* fix(build): add tests and fix bug

Signed-off-by: Samantha Coyle <[email protected]>

* fix(build): add more tests

Signed-off-by: Samantha Coyle <[email protected]>

* style: appease linter

Signed-off-by: Samantha Coyle <[email protected]>

* fix(build): add another test

Signed-off-by: Samantha Coyle <[email protected]>

* test: add even more tests for build to pass lol

Signed-off-by: Samantha Coyle <[email protected]>

---------

Signed-off-by: Samantha Coyle <[email protected]>

* style: rm prefix of == APP ==

Signed-off-by: Samantha Coyle <[email protected]>

* fix(build): grab latest 1.17 runtime

Signed-off-by: Samantha Coyle <[email protected]>

* fix: exclude prereleases

Signed-off-by: Samantha Coyle <[email protected]>

* fix: update readmes for release branch

Signed-off-by: Samantha Coyle <[email protected]>

---------

Signed-off-by: joshvanl <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Albert Callarisa <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Matheus André <[email protected]>
Signed-off-by: Casper Nielsen <[email protected]>
Co-authored-by: Josh van Leeuwen <[email protected]>
Co-authored-by: Albert Callarisa <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Matheus André <[email protected]>
Co-authored-by: Casper Nielsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants