fix(bug): workflow client missing close function to pass to durable task#889
Merged
Merged
Conversation
FarmerChillax
approved these changes
Jan 15, 2026
4 tasks
Contributor
Author
|
@acroca as we discussed this depends on dapr/durabletask-python#39 + new version of Durabletask-Python. Once that has been merged I'll add a version bump to this PR and create another equivalent PR targeting |
3 tasks
Signed-off-by: Casper Nielsen <[email protected]>
Signed-off-by: Casper Nielsen <[email protected]>
…pass down a close call to durabletask Signed-off-by: Casper Nielsen <[email protected]>
CasperGN
force-pushed
the
fix(bug)--workflow-client-close
branch
from
January 16, 2026 10:00
a32a6f9 to
b9da3ad
Compare
acroca
approved these changes
Jan 16, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
+ Coverage 86.63% 86.95% +0.32%
==========================================
Files 84 103 +19
Lines 4473 6900 +2427
==========================================
+ Hits 3875 6000 +2125
- Misses 598 900 +302 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sicoyle
pushed a commit
to sicoyle/python-sdk
that referenced
this pull request
Mar 5, 2026
…ask (dapr#889) * chore(deps): bump dapr dep to 1.17.0.dev Signed-off-by: Casper Nielsen <[email protected]> * chore(deps): bump durabletask-dapr to 0.2.0a15 Signed-off-by: Casper Nielsen <[email protected]> * feat: ensure taskhubgrpcclient expose .close() method for clients to pass down a close call to durabletask Signed-off-by: Casper Nielsen <[email protected]> --------- Signed-off-by: Casper Nielsen <[email protected]>
sicoyle
pushed a commit
to sicoyle/python-sdk
that referenced
this pull request
Mar 5, 2026
…ask (dapr#889) * chore(deps): bump dapr dep to 1.17.0.dev Signed-off-by: Casper Nielsen <[email protected]> * chore(deps): bump durabletask-dapr to 0.2.0a15 Signed-off-by: Casper Nielsen <[email protected]> * feat: ensure taskhubgrpcclient expose .close() method for clients to pass down a close call to durabletask Signed-off-by: Casper Nielsen <[email protected]> --------- Signed-off-by: Casper Nielsen <[email protected]> Signed-off-by: Samantha Coyle <[email protected]>
sicoyle
added a commit
that referenced
this pull request
Mar 6, 2026
* Workflow: remove sleeps from example (#894) * Workflow: remove sleeps from example Remove arbitrary sleeps from workflow examples Signed-off-by: joshvanl <[email protected]> * tox -e ruff Signed-off-by: joshvanl <[email protected]> --------- Signed-off-by: joshvanl <[email protected]> Signed-off-by: Samantha Coyle <[email protected]> * Workflow versioning (#893) Signed-off-by: Albert Callarisa <[email protected]> Signed-off-by: Samantha Coyle <[email protected]> * fix: signal when dt reader stream is ready within wf client start call (#901) * fix: signal when dt reader stream is ready within wf client start call Signed-off-by: Samantha Coyle <[email protected]> * style: appease linter Signed-off-by: Samantha Coyle <[email protected]> * fix: enable configurability + lint fixes Signed-off-by: Samantha Coyle <[email protected]> * fix(build): add tests and fix bug Signed-off-by: Samantha Coyle <[email protected]> * fix(build): add more tests Signed-off-by: Samantha Coyle <[email protected]> * style: appease linter Signed-off-by: Samantha Coyle <[email protected]> * fix(build): add another test Signed-off-by: Samantha Coyle <[email protected]> * test: add even more tests for build to pass lol Signed-off-by: Samantha Coyle <[email protected]> --------- Signed-off-by: Samantha Coyle <[email protected]> * feat(convo): add new fields to conversation api (#902) * feat(convo): add new fields to conversation api Signed-off-by: Samantha Coyle <[email protected]> * fix: update proto/grpc code generator and add more tests Signed-off-by: Samantha Coyle <[email protected]> * style: appease linter Signed-off-by: Samantha Coyle <[email protected]> * style: tox -e type fixes Signed-off-by: Samantha Coyle <[email protected]> --------- Signed-off-by: Samantha Coyle <[email protected]> * add venv (#921) Signed-off-by: Cassandra Coyle <[email protected]> Co-authored-by: Sam <[email protected]> Signed-off-by: Samantha Coyle <[email protected]> * fix: Align Workflow Multi App Naming Convention (#932) Signed-off-by: Matheus André <[email protected]> Signed-off-by: Samantha Coyle <[email protected]> * fix(bug): workflow client missing close function to pass to durable task (#889) * chore(deps): bump dapr dep to 1.17.0.dev Signed-off-by: Casper Nielsen <[email protected]> * chore(deps): bump durabletask-dapr to 0.2.0a15 Signed-off-by: Casper Nielsen <[email protected]> * feat: ensure taskhubgrpcclient expose .close() method for clients to pass down a close call to durabletask Signed-off-by: Casper Nielsen <[email protected]> --------- Signed-off-by: Casper Nielsen <[email protected]> Signed-off-by: Samantha Coyle <[email protected]> * fix: signal when dt reader stream is ready within wf client start call (#901) * fix: signal when dt reader stream is ready within wf client start call Signed-off-by: Samantha Coyle <[email protected]> * style: appease linter Signed-off-by: Samantha Coyle <[email protected]> * fix: enable configurability + lint fixes Signed-off-by: Samantha Coyle <[email protected]> * fix(build): add tests and fix bug Signed-off-by: Samantha Coyle <[email protected]> * fix(build): add more tests Signed-off-by: Samantha Coyle <[email protected]> * style: appease linter Signed-off-by: Samantha Coyle <[email protected]> * fix(build): add another test Signed-off-by: Samantha Coyle <[email protected]> * test: add even more tests for build to pass lol Signed-off-by: Samantha Coyle <[email protected]> --------- Signed-off-by: Samantha Coyle <[email protected]> * style: rm prefix of == APP == Signed-off-by: Samantha Coyle <[email protected]> * fix(build): grab latest 1.17 runtime Signed-off-by: Samantha Coyle <[email protected]> * fix: exclude prereleases Signed-off-by: Samantha Coyle <[email protected]> * fix: update readmes for release branch Signed-off-by: Samantha Coyle <[email protected]> --------- Signed-off-by: joshvanl <[email protected]> Signed-off-by: Samantha Coyle <[email protected]> Signed-off-by: Albert Callarisa <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Matheus André <[email protected]> Signed-off-by: Casper Nielsen <[email protected]> Co-authored-by: Josh van Leeuwen <[email protected]> Co-authored-by: Albert Callarisa <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Matheus André <[email protected]> Co-authored-by: Casper Nielsen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The workflow client did not expose
close()function (as can be seen in the go-sdk. We observed in dapr/dapr-agents that we were unable to pass our closing statement down to the durable task which meant lingering threads.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: