Implement support for cryptography api#719
Conversation
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
KentHsu
changed the title
|
Thank you very much for the PR Kent, I'll try to get to it asap. |
berndverst
left a comment
berndverst
left a comment
There was a problem hiding this comment.
Awesome PR. Thanks @KentHsu
Can you run tox -e flake8 and tox -e ruff please?
The linter is failing at the moment.
That step runs tox -e flake8, tox -e type, tox -e mypy and tox -e ruff.
elena-kolevska
left a comment
elena-kolevska
left a comment
There was a problem hiding this comment.
Great PR @KentHsu, thank you! I have just a few nits.
|
This PR should address the linter failing: #725 |
|
@KentHsu we are beyond code freeze - are you able to address the comments from @elena-kolevska by end of next week? Otherwise, this is unfortunately going to miss the 1.14 release of the SDK. |
|
Currently seeing type check failures as well. I recommend running the above mentioned commands to resolve type check, lint, autoformatting etc |
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
|
Hi @berndverst, @elena-kolevska, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 86.37% 86.59% +0.22%
==========================================
Files 79 84 +5
Lines 4094 4467 +373
==========================================
+ Hits 3536 3868 +332
- Misses 558 599 +41 ☔ View full report in Codecov by Sentry. |
elena-kolevska
left a comment
elena-kolevska
left a comment
There was a problem hiding this comment.
Really great work @KentHsu.
I'm approving the PR so as not to block the release, but to make this contribution 100% complete we would need a little example in the docs (this file) so that developers can discover and use your work.
It would be great if you could send a new PR with that addition.
Thanks again for your contribution, the community appreciates it!
3 participants
Description
Implement below in Dapr gRPC client
Implement below in Dapr gRPC aio client
Add cryptography examples follow go-sdk crypto example
Issue reference
Please reference the issue this PR will close: #548
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: