Proposal: Workflow external event timer tracking#104
Merged
Conversation
Signed-off-by: Albert Callarisa <[email protected]>
JoshVanL
requested changes
Mar 18, 2026
Signed-off-by: Albert Callarisa <[email protected]>
JoshVanL
approved these changes
Mar 19, 2026
This was referenced Mar 20, 2026
Contributor
|
+1 binding |
2 similar comments
Member
|
+1 binding |
Contributor
|
+1 binding |
This was referenced Mar 31, 2026
This was referenced Apr 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today there is no reliable way to tell from the outside which workflow instances are waiting for an external event, or which event they are waiting for. Some SDKs set the timer name to the event name, but that is not enough to distinguish a
waitForExternalEventtimer from a regular timer. On top of that, SDKs that allow indefinite waits (no timeout) don't create a timer at all, making those waits completely invisible.This proposal addresses both gaps by adding a structured
timer_contextfield toCreateTimerActionandTimerCreatedEventin durabletask-protobuf, and requiring SDKs to always create a timer whenwaitForExternalEventis called, using a far-future timestamp when no timeout is specified.