Add error code and category funcs#109
Merged
Merged
Conversation
Signed-off-by: Jake Engelberg <[email protected]>
7 tasks
nelson-parente
approved these changes
Nov 22, 2024
elena-kolevska
suggested changes
Nov 22, 2024
cicoyle
reviewed
Nov 22, 2024
Signed-off-by: Jake Engelberg <[email protected]>
Contributor
Author
Added testing for Also, I've added the prioritization of tag in the |
elena-kolevska
approved these changes
Nov 26, 2024
elena-kolevska
left a comment
elena-kolevska
left a comment
Contributor
There was a problem hiding this comment.
Great work!
We ended up doing the check for the legacy tag twice (you had it right the first time), but that's ok, I don't want to delay this PR.
artursouza
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to support error code metrics, sometimes the category will need to be passed along with a kit error, as well as the ability to retrieve it and its error code.
Issue reference
Please reference the issue this PR will close: dapr/proposals#67
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: