Convert Config API to Stable endpoints. by mukundansundar · Pull Request #846 · dapr/java-sdk

mukundansundar · 2023-04-20T01:45:42Z

Description

Convert Config API to Stable endpoints and client interface.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

Signed-off-by: Mukundan Sundararajan <[email protected]>

pravinpushkar

LGTM

Signed-off-by: Mukundan Sundararajan <[email protected]>

mukundansundar · 2023-04-21T12:21:33Z

@dapr/maintainers-java-sdk For the error with Actors IT, I have created a separate issue in dapr runtime.
dapr/dapr#6268
The example validations with the new APIs pass as expected.

mukundansundar · 2023-04-27T16:38:32Z

@artursouza qq Should this PR be blocked on failures unrelated to config API? I am seeing actors, secrets and service invocation failing with the edge(probably a few days ago) version of dapr

artursouza · 2023-04-27T17:00:47Z

We need to fix upstream. It is concerning to merge a PR that breaks the integration testing.

mukundansundar · 2023-04-27T17:16:35Z

We need to fix upstream. It is concerning to merge a PR that breaks the integration testing.

I do agree on the part of merging something that breaks Java IT.
Then this PR will remain open till changes are done in runtime to fix any issues.

Signed-off-by: Mukundan Sundararajan <[email protected]>

codecov · 2023-05-09T16:27:44Z

Codecov Report

Merging #846 (2441dbc) into master (135b109) will increase coverage by 0.00%.
The diff coverage is 86.66%.

@@            Coverage Diff            @@
##             master     #846   +/-   ##
=========================================
  Coverage     77.92%   77.93%           
- Complexity     1260     1268    +8     
=========================================
  Files           116      116           
  Lines          3892     3902   +10     
  Branches        458      458           
=========================================
+ Hits           3033     3041    +8     
- Misses          627      629    +2     
  Partials        232      232

Impacted Files	Coverage Δ
.../src/main/java/io/dapr/client/DaprClientProxy.java	`76.47% <80.00%> (+0.60%)`	⬆️
...k/src/main/java/io/dapr/client/DaprClientGrpc.java	`89.06% <100.00%> (ø)`
...k/src/main/java/io/dapr/client/DaprClientHttp.java	`86.89% <100.00%> (ø)`

Signed-off-by: Mahmut Canga <[email protected]>

* Add ElementType.Type to ActorType (#812) Signed-off-by: LionTao <[email protected]> Signed-off-by: LionTao <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Bump codecov/codecov-action from 3.1.0 to 3.1.1 (#788) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Update springboot to latest minor.patch version. (#826) Signed-off-by: Mahmut Canga <[email protected]> * Use runtime 1.10.0-rc.X and CLI 1.10.0-rc.X (#827) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Upgrade the version to 1.9.0-SNAPSHOT (#829) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Generate updated javadocs for 1.8.0 (#836) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Update Dapr runtime and CLI to 1.10. (#837) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Inject autoconfiguration in the Spring Boot 3 style (#831) * Bump from spring boot 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <[email protected]> (cherry picked from commit 9152c91) * Ensure old versions of spring boot are still compatible Signed-off-by: Sergio <[email protected]> --------- Signed-off-by: champel <[email protected]> Signed-off-by: Sergio <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Bump from reactor 2.3.5.RELEASE to 2.7.8 (#830) * Bump from reactor 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <[email protected]> * Simplification Signed-off-by: Sergio <[email protected]> --------- Signed-off-by: Sergio <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Test multiple reminder state types + improve timer tests. (#855) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Convert Config API to Stable endpoints. (#846) Signed-off-by: Mahmut Canga <[email protected]> * Add PubSub subscriber examples over gPRC (#833) * add grpc subscriber Signed-off-by: MregXN <[email protected]> * modify README.md Signed-off-by: MregXN <[email protected]> * modify README.md in examples Signed-off-by: MregXN <[email protected]> * Modify DaprApplication to support examples where protocol is not specified. Signed-off-by: MregXN <[email protected]> * modify formatter to pass checkstyle Signed-off-by: MregXN <[email protected]> * Update springboot to latest minor.patch version. (#826) Signed-off-by: MregXN <[email protected]> * Use runtime 1.10.0-rc.X and CLI 1.10.0-rc.X (#827) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: MregXN <[email protected]> * Upgrade the version to 1.9.0-SNAPSHOT (#829) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: MregXN <[email protected]> * Generate updated javadocs for 1.8.0 (#836) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: MregXN <[email protected]> * Update Dapr runtime and CLI to 1.10. (#837) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: MregXN <[email protected]> * Inject autoconfiguration in the Spring Boot 3 style (#831) * Bump from spring boot 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <[email protected]> (cherry picked from commit 9152c91) * Ensure old versions of spring boot are still compatible Signed-off-by: Sergio <[email protected]> --------- Signed-off-by: champel <[email protected]> Signed-off-by: Sergio <[email protected]> Signed-off-by: MregXN <[email protected]> * Bump from reactor 2.3.5.RELEASE to 2.7.8 (#830) * Bump from reactor 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <[email protected]> * Simplification Signed-off-by: Sergio <[email protected]> --------- Signed-off-by: Sergio <[email protected]> Signed-off-by: MregXN <[email protected]> * rerun checks Signed-off-by: MregXN <[email protected]> * modify the way of grpc server starts Signed-off-by: MregXN <[email protected]> * modify README Signed-off-by: MregXN <[email protected]> * Update pom.xml Signed-off-by: MregXN <[email protected]> --------- Signed-off-by: MregXN <[email protected]> Signed-off-by: Artur Souza <[email protected]> Signed-off-by: champel <[email protected]> Signed-off-by: Sergio <[email protected]> Signed-off-by: MregXN <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: champel <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * auto validate actors (#863) Signed-off-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Bump codecov/codecov-action from 3.1.1 to 3.1.4 (#862) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.1...v3.1.4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Mahmut Canga <[email protected]> * Fix 787 (#832) * prepare before testing * Update tests * fix checkstyle --------- Co-authored-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Upgrade to 1.11 RCs. (#867) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Init for workflows Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Updating some javadocs and Years. Signed-off-by: Hannah Kennedy <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Add missing Header Signed-off-by: Hannah Kennedy <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * respond to PR feedback Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Update workflow example README Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Address PR feedback Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * fixup deprecated pom.xml variable Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Updates based on PR feedback Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Update pom files per feedback Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * GetInstanceState implementation (#1) * addiny getInstanceMetadata, waitForInstanceStart and waitForInstanceCompletion implementation --------- Co-authored-by: aymanmahmoud_microsoft <[email protected]> Signed-off-by: Aymand Mahmoud <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Management API Signed-off-by: Mahmut Canga <[email protected]> * remove try/catch Signed-off-by: Mahmut Canga <[email protected]> * implementing getIsReplaying() method for Authoring API (#7) Co-authored-by: Julio Rezende <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Signed-off-by: Julio Rezende <[email protected]> * Implementing getCurrentInstant() authoring method (#5) Co-authored-by: Julio Rezende <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Signed-off-by: Julio Rezende <[email protected]> * Activity Implementation (#3) Signed-off-by: Mahmut Canga <[email protected]> * fixing issue with getIsReplaying() call (#8) Co-authored-by: Julio Rezende <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Signed-off-by: Julio Rezende <[email protected]> * Generate updated javadocs for 1.9.0 (#878) * Generate updated javadocs for 1.9.0 Signed-off-by: Artur Souza <[email protected]> * Update _index.md Signed-off-by: Artur Souza <[email protected]> --------- Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Add .sdkmanrc config file and JDK installation instructions (#873) * Add .sdkmanrc file with installation instructions Signed-off-by: Emanuel Alves <[email protected]> * Update README.md Signed-off-by: Artur Souza <[email protected]> --------- Signed-off-by: Emanuel Alves <[email protected]> Signed-off-by: Artur Souza <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Add unit testing example Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * implementing getIsReplaying() method for Authoring API (#7) Co-authored-by: Julio Rezende <[email protected]> Signed-off-by: Julio Rezende <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * fix parent pom Signed-off-by: Mahmut Canga <[email protected]> * Send Event Implementation (#10) Signed-off-by: Mahmut Canga <[email protected]> * Implementing allOf, anyOf, createTimer methods (#11) Co-authored-by: Julio Rezende <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Co-authored-by: Julio Rezende <[email protected]> * Support remote endpoint. (#877) * Support remote endpoint. Signed-off-by: Artur Souza <[email protected]> * Use GRPC_ENDPOINT and HTTP_ENDPOINT in integration tests. Signed-off-by: Artur Souza <[email protected]> * Fix happy path for waiting for sidecar test. Signed-off-by: Artur Souza <[email protected]> --------- Signed-off-by: Artur Souza <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Add callSubWorkflow Implementation Co-authored-by: Aymand Mahmoud <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Signed-off-by: Aymand Mahmoud <[email protected]> * rename DemoSubWorkflow Co-authored-by: Aymand Mahmoud <[email protected]> Signed-off-by: Aymand Mahmoud <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * continueAsNew Implementation (#13) Signed-off-by: Mahmut Canga <[email protected]> * remove duplicate class Signed-off-by: Mahmut Canga <[email protected]> * add missing mockito test dependency Signed-off-by: Mahmut Canga <[email protected]> * use new workflow client implementation Signed-off-by: Mahmut Canga <[email protected]> * moved implementations to new workflow and context Signed-off-by: Mahmut Canga <[email protected]> * relocate duplicate implemantation Signed-off-by: Mahmut Canga <[email protected]> * remove duplicate test and increase test coverage Signed-off-by: Mahmut Canga <[email protected]> * Implement retry and timeout policy for gRPC client. (#889) * Implement retry and timeout policy for gRPC client. Signed-off-by: Artur Souza <[email protected]> * Fix invoke actor after aborted flow. Signed-off-by: Artur Souza <[email protected]> --------- Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * renamed getIsReplaying Signed-off-by: Mahmut Canga <[email protected]> * rollback changes on client Signed-off-by: Mahmut Canga <[email protected]> * move workflow runtime state package Signed-off-by: Mahmut Canga <[email protected]> * rename workflow instance state to status Signed-off-by: Mahmut Canga <[email protected]> * remove unnecessary else Signed-off-by: Mahmut Canga <[email protected]> * removed unknown state Signed-off-by: Mahmut Canga <[email protected]> * updated comment Signed-off-by: Mahmut Canga <[email protected]> * updated workflow failure details Signed-off-by: Mahmut Canga <[email protected]> * fix style issues Signed-off-by: Mahmut Canga <[email protected]> * rollback merge change Signed-off-by: Mahmut Canga <[email protected]> * fixed pom files Signed-off-by: Mahmut Canga <[email protected]> * rollback actors pom changes on autoformat Signed-off-by: Mahmut Canga <[email protected]> * fixe actors pom Signed-off-by: Mahmut Canga <[email protected]> * fix styling on actors pom Signed-off-by: Mahmut Canga <[email protected]> * fix pom spacing Signed-off-by: Mahmut Canga <[email protected]> * move test to match the package Signed-off-by: Mahmut Canga <[email protected]> * add missing dependencies Signed-off-by: Mahmut Canga <[email protected]> * increased test coverage Signed-off-by: Mahmut Canga <[email protected]> * moved workflow runtime package Signed-off-by: Mahmut Canga <[email protected]> * add exception for missing case Signed-off-by: Mahmut Canga <[email protected]> * add null check for metadata Signed-off-by: Mahmut Canga <[email protected]> * add runtime exception error messages Signed-off-by: Mahmut Canga <[email protected]> * update try catch scope Signed-off-by: Mahmut Canga <[email protected]> * update activity definition to an interface Signed-off-by: Mahmut Canga <[email protected]> * update comments Signed-off-by: Mahmut Canga <[email protected]> * removed redundant method Signed-off-by: Mahmut Canga <[email protected]> * PR updates Signed-off-by: Mahmut Canga <[email protected]> --------- Signed-off-by: LionTao <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Artur Souza <[email protected]> Signed-off-by: champel <[email protected]> Signed-off-by: Sergio <[email protected]> Signed-off-by: MregXN <[email protected]> Signed-off-by: MregXN <[email protected]> Signed-off-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Hannah Kennedy <[email protected]> Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Aymand Mahmoud <[email protected]> Signed-off-by: Julio Rezende <[email protected]> Signed-off-by: Emanuel Alves <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Co-authored-by: LionTao <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: champel <[email protected]> Co-authored-by: MregXN <[email protected]> Co-authored-by: MatejNedic <[email protected]> Co-authored-by: Bill DeRusha <[email protected]> Co-authored-by: Hannah Kennedy <[email protected]> Co-authored-by: Bill DeRusha <[email protected]> Co-authored-by: Aymalla <[email protected]> Co-authored-by: aymanmahmoud_microsoft <[email protected]> Co-authored-by: swetakumari <[email protected]> Co-authored-by: julio <[email protected]> Co-authored-by: Julio Rezende <[email protected]> Co-authored-by: Emanuel Alves <[email protected]> Co-authored-by: Artur Souza <[email protected]>

mukundansundar added 4 commits April 20, 2023 07:14

Convert Config API to Stable endpoints.

a4ccfcb

Signed-off-by: Mukundan Sundararajan <[email protected]>

Fix dapr build and validate ref.

dd91e65

Signed-off-by: Mukundan Sundararajan <[email protected]>

Fix GH workflow Golang version.

a6f610d

Signed-off-by: Mukundan Sundararajan <[email protected]>

Fix GH workflow Golang version.

a122c74

Signed-off-by: Mukundan Sundararajan <[email protected]>

pravinpushkar previously approved these changes Apr 20, 2023

View reviewed changes

fix config client example

de8d85c

Signed-off-by: Mukundan Sundararajan <[email protected]>

mukundansundar dismissed pravinpushkar’s stale review via de8d85c April 21, 2023 10:10

fix config api validation output

bf40449

Signed-off-by: Mukundan Sundararajan <[email protected]>

mukundansundar added the breaking-change label Apr 21, 2023

mukundansundar marked this pull request as ready for review April 21, 2023 12:19

mukundansundar requested review from a team as code owners April 21, 2023 12:19

shivamkm07 mentioned this pull request Apr 25, 2023

Proposal: Make Configuration API stable dapr/dapr#5522

Closed

32 tasks

mukundansundar added 3 commits May 9, 2023 09:23

Merge remote-tracking branch 'upstream/master' into stable-config-api

317af8b

use latest dapr commit sha

8e81d62

Signed-off-by: Mukundan Sundararajan <[email protected]>

use latest dapr commit sha

2441dbc

Signed-off-by: Mukundan Sundararajan <[email protected]>

artursouza approved these changes May 9, 2023

View reviewed changes

artursouza merged commit aaa5f7b into dapr:master May 9, 2023

mukundansundar added this to the v1.9 milestone May 9, 2023

mukundansundar deleted the stable-config-api branch May 9, 2023 17:59

artursouza mentioned this pull request May 16, 2023

v1.11 Endgame dapr/dapr#6301

Closed

macromania pushed a commit to ISE-Neutrino/java-sdk that referenced this pull request Jun 21, 2023

Convert Config API to Stable endpoints. (dapr#846)

022c0ee

Signed-off-by: Mahmut Canga <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Convert Config API to Stable endpoints.#846

Convert Config API to Stable endpoints.#846
artursouza merged 9 commits into
dapr:masterfrom
mukundansundar:stable-config-api

mukundansundar commented Apr 20, 2023

Uh oh!

pravinpushkar left a comment

Uh oh!

mukundansundar commented Apr 21, 2023

Uh oh!

mukundansundar commented Apr 27, 2023

Uh oh!

artursouza commented Apr 27, 2023

Uh oh!

mukundansundar commented Apr 27, 2023

Uh oh!

codecov Bot commented May 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mukundansundar commented Apr 20, 2023

Description

Issue reference

Checklist

Uh oh!

pravinpushkar left a comment

Choose a reason for hiding this comment

Uh oh!

mukundansundar commented Apr 21, 2023

Uh oh!

mukundansundar commented Apr 27, 2023

Uh oh!

artursouza commented Apr 27, 2023

Uh oh!

mukundansundar commented Apr 27, 2023

Uh oh!

codecov Bot commented May 9, 2023

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants