IT test for long values by tanvigour · Pull Request #713 · dapr/java-sdk

tanvigour · 2022-03-23T15:17:48Z

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #686

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

Signed-off-by: tanvigour <[email protected]>

mukundansundar · 2022-03-23T15:36:17Z

+            "messages/testinglongvalues",
+            null,
+            HttpExtension.GET, CLOUD_EVENT_LIST_TYPE_REF).block();
+        assertEquals(590518626939830271L, messages.get(0).getData());


@tanvigour Why do we have to publish N messages and then check only one message ?

we can check for all values, just added a commit for that

Signed-off-by: tanvigour <[email protected]>

mukundansundar

overall lgtm ... if possible test for larger values of long and varied values ....

Signed-off-by: tanvigour <[email protected]>

mukundansundar · 2022-03-25T17:54:58Z

@tanvigour
update workflow files to point to the right dapr commit which has the fix ...

Signed-off-by: tanvigour <[email protected]>

mukundansundar

@tanvigour Please address these comments.

mukundansundar · 2022-03-26T06:43:08Z

  }
+
+  public static class ConvertToLong {
+    public Long value;


mukundansundar · 2022-03-26T06:43:55Z

+    public void setVal(Long value) {
+      this.value = value;
+    }
+  }


Add getter for value, and equals and Dashcode method (Can autogenerate in IntelliJ using Objects.hash etc ).

mukundansundar · 2022-03-26T06:45:43Z

+    }
+
+    ConvertToLong value = new ConvertToLong();
+    value.setVal(590518626939830271L);


Create a Random object to generate random values with 590518626939830271L as seed.
Create a Set HashSet,
Add 590518626939830271L as the first element.
Add more random long values upto NUM_MESSAGES size.

mukundansundar · 2022-03-26T06:46:20Z

+        client.publishEvent(
+            PUBSUB_NAME,
+            LONG_TOPIC_NAME,
+            value,


create iterator of the set, and send the next element here.

mukundansundar · 2022-03-26T06:46:57Z

+            daprRun.getAppName(),
+            "messages/testinglongvalues",
+            null,
+            HttpExtension.GET, CLOUD_EVENT_LIST_TYPE_REF).block();


ADD an new TypeRef
private static final TypeRef<List<CloudEvent<ConvertToLong>>> CLOUD_EVENT_LONG_LIST_TYPE_REF = new TypeRef<>() {};
use that here .

mukundansundar · 2022-03-26T06:47:59Z

+            null,
+            HttpExtension.GET, CLOUD_EVENT_LIST_TYPE_REF).block();
+        for (int i = 0; i < NUM_MESSAGES; i++) { 
+          System.out.println("The long value received!!! " +messages.get(i).getData().value);


remove log.

mukundansundar · 2022-03-26T06:48:40Z

+            "messages/testinglongvalues",
+            null,
+            HttpExtension.GET, CLOUD_EVENT_LIST_TYPE_REF).block();
+        for (int i = 0; i < NUM_MESSAGES; i++) { 


Suggested change

for (int i = 0; i < NUM_MESSAGES; i++) {

Assert.assertNotNull(messages);

for (int i = 0; i < messages.size(); i++) {

mukundansundar · 2022-03-26T06:50:36Z

+            HttpExtension.GET, CLOUD_EVENT_LIST_TYPE_REF).block();
+        for (int i = 0; i < NUM_MESSAGES; i++) { 
+          System.out.println("The long value received!!! " +messages.get(i).getData().value);
+          assertEquals(590518626939830271L, messages.get(i).getData().value);


Add it to the actual ConvertToLong Set created above.

actual.add(message.getData()

mukundansundar · 2022-03-26T06:51:37Z

+          assertEquals(590518626939830271L, messages.get(i).getData().value);
+        }
+      }, 2000);
+    }


Add assert comparing two set values

Assert.assertEquals(expected, actual);

Both expected and actual are of type Set<ConvertToLong

mukundansundar · 2022-03-26T06:51:48Z

  }

+  @Test
+  public void testlongValues() throws Exception {


Suggested change

public void testlongValues() throws Exception {

public void testLongValues() throws Exception {

Signed-off-by: tanvigour <[email protected]>

mukundansundar · 2022-03-28T20:21:44Z

Tested this locally ... it is working ... with latest master Dapr after contrib 1.7-rc merge

Confirmed listening on port 58606.
Dapr application started.
The long value sent 590518626939830271
== APP == Subscriber got: 590518626939830271
The long value sent 9162974433530815171
== APP == Subscriber got: 9162974433530815171
The long value sent 2803002362178450485
== APP == Subscriber got: 2803002362178450485
The long value sent 1005463900081880990
== APP == Subscriber got: 1005463900081880990
The long value sent 4093312918519397196
== APP == Subscriber got: 4093312918519397196
The long value sent 5939038007520118028
== APP == Subscriber got: 5939038007520118028
The long value sent 7145089449735285569
== APP == Subscriber got: 7145089449735285569
The long value sent 4024458962230509193
== APP == Subscriber got: 4024458962230509193
The long value sent 2837854465277681257
== APP == Subscriber got: 2837854465277681257
The long value sent 562839771211708662
== APP == Subscriber got: 562839771211708662
Checking results for topic testinglongvalues

@tanvigour is the test working for you locally ?

…ue to set Signed-off-by: tanvigour <[email protected]>

Signed-off-by: tanvigour <[email protected]>

codecov · 2022-03-29T15:49:45Z

Codecov Report

Merging #713 (ddcd2b3) into master (c7cc94d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #713   +/-   ##
=========================================
  Coverage     78.19%   78.19%           
  Complexity     1117     1117           
=========================================
  Files            97       97           
  Lines          3417     3417           
  Branches        399      399           
=========================================
  Hits           2672     2672           
  Misses          547      547           
  Partials        198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7cc94d...ddcd2b3. Read the comment docs.

mukundansundar

lgtm
cc @artursouza

* run IT test for long values Signed-off-by: tanvigour <[email protected]> * Fix the class name Signed-off-by: tanvigour <[email protected]> * assert for all messages and fix class name Signed-off-by: tanvigour <[email protected]> * test for Long.MAX_VALUE Signed-off-by: tanvigour <[email protected]> * revert back long number and print Signed-off-by: tanvigour <[email protected]> * fix the typo Signed-off-by: tanvigour <[email protected]> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <[email protected]> * log some more data to debug Signed-off-by: tanvigour <[email protected]> * debug Signed-off-by: tanvigour <[email protected]> * get the value from messages Signed-off-by: tanvigour <[email protected]> * address feedback Signed-off-by: tanvigour <[email protected]> * change the assertion Signed-off-by: tanvigour <[email protected]> * Add hashcode and equals functione and create new obj while adding value to set Signed-off-by: tanvigour <[email protected]> * move iterator Signed-off-by: tanvigour <[email protected]> * log value before adding to hashset Signed-off-by: tanvigour <[email protected]> * log value before adding to hashset Signed-off-by: tanvigour <[email protected]> * log value before adding to hashset Signed-off-by: tanvigour <[email protected]> * change assertion Signed-off-by: tanvigour <[email protected]> * fix equals method Signed-off-by: tanvigour <[email protected]> * adding debugging for expected value Signed-off-by: tanvigour <[email protected]> * adding logs for expected value Signed-off-by: tanvigour <[email protected]> * log value before adding to hashset Signed-off-by: tanvigour <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Artur Souza <[email protected]>

run IT test for long values

c759e2d

Signed-off-by: tanvigour <[email protected]>

tanvigour requested review from a team as code owners March 23, 2022 15:17

Fix the class name

afc31e6

Signed-off-by: tanvigour <[email protected]>

mukundansundar reviewed Mar 23, 2022

View reviewed changes

mukundansundar and others added 2 commits March 23, 2022 21:20

Merge branch 'master' into tanvi/test_longvalues

b913cf9

assert for all messages and fix class name

fa8f19d

Signed-off-by: tanvigour <[email protected]>

mukundansundar reviewed Mar 23, 2022

View reviewed changes

tanvigour and others added 4 commits March 24, 2022 11:44

Merge branch 'master' into tanvi/test_longvalues

52bcadc

test for Long.MAX_VALUE

a31516f

Signed-off-by: tanvigour <[email protected]>

revert back long number and print

acd4a32

Signed-off-by: tanvigour <[email protected]>

fix the typo

bf825b1

Signed-off-by: tanvigour <[email protected]>

tanvigour added 4 commits March 25, 2022 13:57

update the latest dapr commit in workflow files

ba29451

Signed-off-by: tanvigour <[email protected]>

log some more data to debug

4ba4859

Signed-off-by: tanvigour <[email protected]>

debug

93a5943

Signed-off-by: tanvigour <[email protected]>

get the value from messages

09c52af

Signed-off-by: tanvigour <[email protected]>

mukundansundar reviewed Mar 26, 2022

View reviewed changes

tanvigour added 2 commits March 28, 2022 15:31

address feedback

5b4f1d7

Signed-off-by: tanvigour <[email protected]>

change the assertion

c40af0a

Signed-off-by: tanvigour <[email protected]>

tanvigour added 9 commits March 28, 2022 17:19

Add hashcode and equals functione and create new obj while adding val…

f0b5663

…ue to set Signed-off-by: tanvigour <[email protected]>

move iterator

fca6921

Signed-off-by: tanvigour <[email protected]>

log value before adding to hashset

c798729

Signed-off-by: tanvigour <[email protected]>

log value before adding to hashset

c81363f

Signed-off-by: tanvigour <[email protected]>

log value before adding to hashset

77006cb

Signed-off-by: tanvigour <[email protected]>

change assertion

113baf5

Signed-off-by: tanvigour <[email protected]>

fix equals method

0f7f2f8

Signed-off-by: tanvigour <[email protected]>

adding debugging for expected value

2240671

Signed-off-by: tanvigour <[email protected]>

adding logs for expected value

f2de558

Signed-off-by: tanvigour <[email protected]>

log value before adding to hashset

ddcd2b3

Signed-off-by: tanvigour <[email protected]>

mukundansundar approved these changes Mar 29, 2022

View reviewed changes

artursouza approved these changes Mar 29, 2022

View reviewed changes

artursouza merged commit 1ce6738 into dapr:master Mar 29, 2022

	for (int i = 0; i < NUM_MESSAGES; i++) {
	Assert.assertNotNull(messages);
	for (int i = 0; i < messages.size(); i++) {

	public void testlongValues() throws Exception {
	public void testLongValues() throws Exception {

Uh oh!

Conversation

tanvigour commented Mar 23, 2022

Description

Issue reference

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mukundansundar left a comment

Choose a reason for hiding this comment

Uh oh!

mukundansundar commented Mar 25, 2022

Uh oh!

mukundansundar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mukundansundar commented Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 29, 2022

Codecov Report

Uh oh!

mukundansundar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mukundansundar commented Mar 28, 2022 •

edited

Loading