Renaming streaming subscription to "subscribeToTopic"#1626
Merged
Conversation
Contributor
Author
|
@dapr/approvers-java-sdk and @dapr/maintainers-java-sdk could you please take a look. I think this should be the final name for streaming subscription and it aligns with other SDKs nicely. @alicejgibbons @javier-aliaga @cicoyle could you also please take a look. Thank you 🙇 |
cicoyle
approved these changes
Jan 27, 2026
cicoyle
requested changes
Jan 27, 2026
cicoyle
left a comment
cicoyle
left a comment
Contributor
There was a problem hiding this comment.
Can we create an alias for this so we dont break users. This functionality was backported, so I think its best to add an alias and mark the old as deprecated to be removed later.
artur-ciocanu
force-pushed
the
subscribe-to-topic
branch
from
January 31, 2026 01:37
c802e76 to
49a4b03
Compare
Contributor
Author
|
@cicoyle @salaboy and @javier-aliaga I have added aliases so we keep backward compatibility. |
Contributor
|
@artur-ciocanu ok.. so there is a codecov gap there.. I promise you, I will fix the reports soon, but basically, you need to keep a couple of tests for the previous signature of the method. |
salaboy
self-requested a review
February 3, 2026 10:44
salaboy
requested changes
Feb 3, 2026
salaboy
left a comment
salaboy
left a comment
Contributor
There was a problem hiding this comment.
LGTM, it just need the codecov report green
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
artur-ciocanu
force-pushed
the
subscribe-to-topic
branch
from
February 7, 2026 07:06
d0f605a to
4aea0fd
Compare
Contributor
Author
Contributor
Author
Contributor
|
@artur-ciocanu done |
cicoyle
approved these changes
Feb 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1626 +/- ##
=========================================
Coverage 79.26% 79.26%
- Complexity 2144 2146 +2
=========================================
Files 234 234
Lines 6462 6464 +2
Branches 700 700
=========================================
+ Hits 5122 5124 +2
Misses 987 987
Partials 353 353 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
javier-aliaga
pushed a commit
to javier-aliaga/java-sdk
that referenced
this pull request
Feb 17, 2026
* Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]>
javier-aliaga
pushed a commit
to javier-aliaga/java-sdk
that referenced
this pull request
Feb 17, 2026
* Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
dapr-bot
added a commit
that referenced
this pull request
Feb 17, 2026
* Renaming streaming subscription to "subscribeToTopic". * Bring back subscribeToEvents for backward compatibility. * Fix rebase conflicts * Add tests for deprecated events methods. --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 17, 2026
* Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 17, 2026
* Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 17, 2026
* Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 17, 2026
* Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 17, 2026
* Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
pushed a commit
to salaboy/java-sdk
that referenced
this pull request
Feb 17, 2026
* Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]>
salaboy
added a commit
that referenced
this pull request
Feb 20, 2026
* initial restructure for spring-boot-4-autoconfigure Signed-off-by: salaboy <[email protected]> * updating sb4 with Jackson3 support and tests Signed-off-by: salaboy <[email protected]> * Renaming streaming subscription to "subscribeToTopic" (#1626) * Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]> * fixing new packages Signed-off-by: salaboy <[email protected]> * fixing sdk-tests Signed-off-by: salaboy <[email protected]> * updating test coverage Signed-off-by: salaboy <[email protected]> * missing package from example test Signed-off-by: salaboy <[email protected]> * aliging test junit version Signed-off-by: salaboy <[email protected]> * fixing spring boot 3 new packages Signed-off-by: salaboy <[email protected]> * increase test coverage for jackson3 Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]>
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
* initial restructure for spring-boot-4-autoconfigure Signed-off-by: salaboy <[email protected]> * updating sb4 with Jackson3 support and tests Signed-off-by: salaboy <[email protected]> * Renaming streaming subscription to "subscribeToTopic" (#1626) * Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]> * fixing new packages Signed-off-by: salaboy <[email protected]> * fixing sdk-tests Signed-off-by: salaboy <[email protected]> * updating test coverage Signed-off-by: salaboy <[email protected]> * missing package from example test Signed-off-by: salaboy <[email protected]> * aliging test junit version Signed-off-by: salaboy <[email protected]> * fixing spring boot 3 new packages Signed-off-by: salaboy <[email protected]> * increase test coverage for jackson3 Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> (cherry picked from commit 834b6b3)
javier-aliaga
added a commit
to javier-aliaga/java-sdk
that referenced
this pull request
Feb 20, 2026
…pr#1660) * Renaming streaming subscription to "subscribeToTopic". * Bring back subscribeToEvents for backward compatibility. * Fix rebase conflicts * Add tests for deprecated events methods. --------- Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
javier-aliaga
pushed a commit
to javier-aliaga/java-sdk
that referenced
this pull request
Feb 20, 2026
* initial restructure for spring-boot-4-autoconfigure Signed-off-by: salaboy <[email protected]> * updating sb4 with Jackson3 support and tests Signed-off-by: salaboy <[email protected]> * Renaming streaming subscription to "subscribeToTopic" (dapr#1626) * Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]> * fixing new packages Signed-off-by: salaboy <[email protected]> * fixing sdk-tests Signed-off-by: salaboy <[email protected]> * updating test coverage Signed-off-by: salaboy <[email protected]> * missing package from example test Signed-off-by: salaboy <[email protected]> * aliging test junit version Signed-off-by: salaboy <[email protected]> * fixing spring boot 3 new packages Signed-off-by: salaboy <[email protected]> * increase test coverage for jackson3 Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> (cherry picked from commit 834b6b3) Signed-off-by: Javier Aliaga <[email protected]>
javier-aliaga
pushed a commit
to javier-aliaga/java-sdk
that referenced
this pull request
Feb 20, 2026
* initial restructure for spring-boot-4-autoconfigure Signed-off-by: salaboy <[email protected]> * updating sb4 with Jackson3 support and tests Signed-off-by: salaboy <[email protected]> * Renaming streaming subscription to "subscribeToTopic" (dapr#1626) * Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]> * fixing new packages Signed-off-by: salaboy <[email protected]> * fixing sdk-tests Signed-off-by: salaboy <[email protected]> * updating test coverage Signed-off-by: salaboy <[email protected]> * missing package from example test Signed-off-by: salaboy <[email protected]> * aliging test junit version Signed-off-by: salaboy <[email protected]> * fixing spring boot 3 new packages Signed-off-by: salaboy <[email protected]> * increase test coverage for jackson3 Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]>
dapr-bot
added a commit
that referenced
this pull request
Feb 20, 2026
* Supporting Jackson3 DaprObjectSerializer (#1657) * initial restructure for spring-boot-4-autoconfigure Signed-off-by: salaboy <[email protected]> * updating sb4 with Jackson3 support and tests Signed-off-by: salaboy <[email protected]> * Renaming streaming subscription to "subscribeToTopic" (#1626) * Renaming streaming subscription to "subscribeToTopic". Signed-off-by: Artur Ciocanu <[email protected]> * Bring back subscribeToEvents for backward compatibility. Signed-off-by: Artur Ciocanu <[email protected]> * Fix rebase conflicts Signed-off-by: Artur Ciocanu <[email protected]> * Add tests for deprecated events methods. Signed-off-by: Artur Ciocanu <[email protected]> --------- Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]> * fixing new packages Signed-off-by: salaboy <[email protected]> * fixing sdk-tests Signed-off-by: salaboy <[email protected]> * updating test coverage Signed-off-by: salaboy <[email protected]> * missing package from example test Signed-off-by: salaboy <[email protected]> * aliging test junit version Signed-off-by: salaboy <[email protected]> * fixing spring boot 3 new packages Signed-off-by: salaboy <[email protected]> * increase test coverage for jackson3 Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> * chore: Fix pom Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Artur Ciocanu <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renaming streaming subscription to "subscribeToTopic". This should align better with other Dapr SDKs and ensure that is more ergonomic.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: