Adds FailurePolicy to ActorReminder registration#793
Merged
Conversation
Signed-off-by: joshvanl <[email protected]>
JoshVanL
force-pushed
the
actor-reminder-failure-policy
branch
from
January 6, 2026 14:23
5dc171b to
36d87d1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
===========================================
- Coverage 62.52% 51.07% -11.46%
===========================================
Files 56 57 +1
Lines 4139 3785 -354
===========================================
- Hits 2588 1933 -655
- Misses 1425 1715 +290
- Partials 126 137 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@mikeee not quite sure what is going on here with the Dapr CLI env var 🤔 |
nelson-parente
approved these changes
Jan 15, 2026
cicoyle
approved these changes
Jan 16, 2026
cicoyle
left a comment
cicoyle
left a comment
Contributor
There was a problem hiding this comment.
changes lgtm but CI is very red
mikeee
approved these changes
Jan 16, 2026
Member
|
lgtm - Just needed to trigger the setup job again, currently doesn't seem like it fails or validates the github version lookup response. This fails due to being rate limited |
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.