Skip to content

Bidirectional Subscriptions#578

Merged
yaron2 merged 8 commits into
dapr:mainfrom
JoshVanL:bi-di-pubsub
Jul 11, 2024
Merged

Bidirectional Subscriptions#578
yaron2 merged 8 commits into
dapr:mainfrom
JoshVanL:bi-di-pubsub

Conversation

@JoshVanL

@JoshVanL JoshVanL commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

Adds support for bidirectional subscriptions to PubSubs. Adds two methods for subscribing- one using a callback and one using an imperative approach. Both giving support to different programming styles or use cases.

Adds example with tests.

Requires daprd built from dapr/dapr#7770

@JoshVanL
JoshVanL requested review from a team as code owners June 19, 2024 15:19
@codecov

codecov Bot commented Jun 19, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 2.58621% with 113 lines in your changes missing coverage. Please review.

Project coverage is 62.05%. Comparing base (27248ba) to head (32b4f4b).
Report is 18 commits behind head on main.

Files Patch % Lines
client/subscribe.go 0.00% 113 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   58.04%   62.05%   +4.00%     
==========================================
  Files          55       53       -2     
  Lines        3568     3352     -216     
==========================================
+ Hits         2071     2080       +9     
+ Misses       1375     1151     -224     
+ Partials      122      121       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Jun 25, 2024
mikeee
mikeee previously approved these changes Jul 2, 2024

@mikeee mikeee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

JoshVanL and others added 7 commits July 9, 2024 14:19
Adds support for bidirectional subscriptions to PubSubs. Adds two
methods for subscribing- one using a callback and one using an
imperative approach. Both giving support to different programming styles
or use cases.

Adds example with tests.

Signed-off-by: joshvanl <[email protected]>

@mikeee mikeee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yaron2

yaron2 commented Jul 11, 2024

Copy link
Copy Markdown
Member

the validation step is failing

@mikeee

mikeee commented Jul 11, 2024

Copy link
Copy Markdown
Member

the validation step is failing

It fails as the validation is running the latest version of Dapr rather than the RC.

I've validated with RC2 and it's smooth as butter 🙂 we could set the validation workflow to 1.14.0-rc.2 on the release branch if that helps push this through.

@yaron2
yaron2 merged commit b7b90e3 into dapr:main Jul 11, 2024
@yaron2

yaron2 commented Jul 11, 2024

Copy link
Copy Markdown
Member

Can't argue with "smooth as butter" :)

@marcduiker

Copy link
Copy Markdown
Contributor

@holopin-bot @JoshVanL Thanks Josh!

@holopin-bot

holopin-bot Bot commented Aug 15, 2024

Copy link
Copy Markdown

Congratulations @JoshVanL, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvb8tyf10350cmgajs8h4lq

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants