Implement Bulk Publish functionality#1001
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
+ Coverage 69.92% 70.15% +0.22%
==========================================
Files 157 160 +3
Lines 5227 5284 +57
Branches 562 567 +5
==========================================
+ Hits 3655 3707 +52
- Misses 1439 1443 +4
- Partials 133 134 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Hello @yash-nisar, did you get a chance to look into dapr/sig-sdk-spec#22? It's still something I am figuring out, but with implementations across SDKs we can make both the SIG specification and SDK PRs consistent. |
Contributor
Author
|
Hey @shubham1172 , not yet. Will look at it and make the necessary modifications. However, I've mostly tried to be consistent with dapr/java-sdk#789. Thanks for bringing this up ! |
halspang
requested changes
Jan 13, 2023
yash-nisar
force-pushed
the
bulk_publish
branch
from
January 18, 2023 01:26
5729afc to
c1fef0c
Compare
halspang
reviewed
Jan 24, 2023
halspang
left a comment
halspang
left a comment
Contributor
There was a problem hiding this comment.
Code looks fine, I think you just need to update the example README to state which subscriber needs to be running.
Contributor
|
Oh, and please fix the merge conflicts. |
yash-nisar
force-pushed
the
bulk_publish
branch
2 times, most recently
from
January 25, 2023 03:19
61a4faf to
bf9f966
Compare
yash-nisar
force-pushed
the
bulk_publish
branch
from
January 26, 2023 07:47
bf9f966 to
381683c
Compare
Closes dapr#958 Signed-off-by: Yash Nisar <[email protected]>
yash-nisar
force-pushed
the
bulk_publish
branch
from
January 26, 2023 07:49
381683c to
532ec79
Compare
halspang
approved these changes
Jan 26, 2023
mukundansundar
approved these changes
Jan 26, 2023
64 tasks
4 tasks
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yash Nisar [email protected]
Description
Implement Bulk Publish functionality
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #958
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: