docs: clarify continue-as-new behavior for child workflows #5021#5130
Merged
marcduiker merged 6 commits intoJun 4, 2026
Merged
Conversation
Signed-off-by: pittu sharma <[email protected]>
nelson-parente
left a comment
nelson-parente
left a comment
Contributor
There was a problem hiding this comment.
Pre-review for @marcduiker handoff: LGTM with nits.
- The continue-as-new alert boxes are a useful clarification for the monitor pattern and infinite loop sections.
- Comment improvements (replacing generic placeholders with business-logic descriptions) are a nice polish.
- The maintainer-guide.md changes (azd auth login, remove stale SDK doc pull section) overlap with #5083 and #5101 from the same author — Marc, one of these three PRs has the maintainer-guide fix and all appear to land the same change. Confirm only one gets merged to avoid conflicts.
- Nit: the Python comment fix from
# Apply some compensating workto# Add logic here to undo partial changesaccidentally appears under a JS code block (// Add logic here...) — the JS block fix looks correct; the Python snippet looks fine too.
Nothing blocking — Marc, your call.
This was referenced May 19, 2026
marcduiker
reviewed
Jun 1, 2026
Signed-off-by: Marc Duiker <[email protected]>
marcduiker
reviewed
Jun 4, 2026
Signed-off-by: Marc Duiker <[email protected]>
Contributor
|
@holopin-bot @Pittu-Sharma docs-badge Thank you! Here's a digital badge as a small token of appreciation. |
|
Congratulations @Pittu-Sharma, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmqbfawoz0009ks0brog4liyj This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #5021 by explicitly clarifying the behavior of the
continue-as-newAPI regarding unawaited child workflows. This is a critical detail for developers implementing the Monitor Pattern, ascontinue-as-newproceeds immediately and does not wait for child workflows started viaCallChildWorkflowAsync(or equivalent SDK methods) unless they are explicitly awaited.Key Changes:
{{% alert %}}boxes to the Monitor pattern section inworkflow-patterns.mdand the Infinite loops section inworkflow-features-concepts.md.// Do some work) have been replaced with descriptive, professional business logic markers (e.g.,// Initial business logic (e.g., inventory check)).#in JS blocks) and typos ("cancled" to "cancelled").Issue reference
Closes #5021