Listed missing HTTP and gRPC endpoint envvars used#4313
Merged
Conversation
Signed-off-by: Whit Waldo <[email protected]>
msfussell
reviewed
Aug 15, 2024
Member
There was a problem hiding this comment.
@WhitWaldo - These are great missing additions. See my comments on examples to help developers.
Signed-off-by: Whit Waldo <[email protected]>
Contributor
Author
|
@msfussell For both examples, I'll come back and edit the language in the docs if/when another PR I created today is accepted and merged. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
I noticed that the published page listing the various environment variables was missing two of the values used today:
DAPR_HTTP_ENDPOINTandDAPR_GRPC_ENDPOINT, so I've added them to the list.Issue reference
N/A