Skip to content

Add content that translated into zh_Hans#1286

Merged
AaronCrawfis merged 6 commits into
dapr:v1.0from
newbe36524:v1.0
Mar 5, 2021
Merged

Add content that translated into zh_Hans#1286
AaronCrawfis merged 6 commits into
dapr:v1.0from
newbe36524:v1.0

Conversation

@newbe36524

Copy link
Copy Markdown
Contributor

Please follow this checklist before submitting:

  • [ x Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Add Content from docs-zh repo as l18n content in zh_Hans

Issue reference

#1057

@ghost

ghost commented Mar 4, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@orizohar
orizohar requested a review from AaronCrawfis March 4, 2021 18:02

@AaronCrawfis AaronCrawfis left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Tested it out on my side and functionally everything looks good, just 2 notes on renaming the directory with the submodule and fixing the titles of the pages to say "Dapr Docs" instead of the language name

Comment thread daprdocs/config.toml Outdated
Comment thread daprdocs/config.toml Outdated
Comment thread .gitmodules Outdated
Comment thread .gitmodules Outdated
Comment thread daprdocs/config.toml Outdated
Comment thread daprdocs/config.toml Outdated
Comment thread daprdocs/config.toml Outdated
Comment thread daprdocs/config.toml Outdated
Comment thread daprdocs/config.toml Outdated
@newbe36524

Copy link
Copy Markdown
Contributor Author

Thank you for your contribution! Tested it out on my side and functionally everything looks good, just 2 notes on renaming the directory with the submodule and fixing the titles of the pages to say "Dapr Docs" instead of the language name

Thanks, I have updated as your suggestion

@AaronCrawfis
AaronCrawfis merged commit ba144bc into dapr:v1.0 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants