Skip to content

fix: check for multiple avenues of errs on mcp tools - #423

Closed
sicoyle wants to merge 1 commit into
dapr:mainfrom
sicoyle:fix-mcp-tool-err-catch
Closed

sicoyle wants to merge 1 commit into
dapr:mainfrom
sicoyle:fix-mcp-tool-err-catch

Conversation

@sicoyle

@sicoyle sicoyle commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator

Description

i was seeing this mcp tool err

lResult'>)
GithubGetReleaseByTag(tool) (Id: call_eECqd2eObRNweLdG2AHHfMTZ):
{"meta": null, "content": [{"type": "text", "text": "missing required parameter: owner", "annotations": null, "meta": null}], "structured_content": null, "is_error": false}

-----------------------------------------------

So we need to adjust our MCP tool err handling to support cases where is_error is not always set appropriately

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR closes: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Created/updated tests
  • Tested this change against all the quickstarts
  • Extended the documentation

Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.

@sicoyle
sicoyle requested review from a team as code owners February 2, 2026 21:33
@sicoyle

sicoyle commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator Author

gonna go ahead and close this as this is an MCP server issue not something we should fix here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant