Skip to content

Fix/281 session aware memory#292

Merged
yaron2 merged 5 commits into
dapr:mainfrom
CasperGN:fix/281-session-aware-memory
Dec 4, 2025
Merged

Fix/281 session aware memory#292
yaron2 merged 5 commits into
dapr:mainfrom
CasperGN:fix/281-session-aware-memory

Conversation

@CasperGN

@CasperGN CasperGN commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Description

Implement session aware handling of saving memory. This fixes the

Error received from peer ipv4:127.0.0.1:50451 {grpc_status:10, grpc_message:"failed saving state in state store workflowstatestore: possible etag mismatch.

Error when running fan-out during run_tool or when running several invocations concurrently.

Subsequently, this fix also handles the issue with concurrent invocations with fan-out run_tool that could result in the tool call order to be scrambled which caused issues with OpenAI.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #281

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Created/updated tests
  • Tested this change against all the quickstarts
  • Extended the documentation

Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.

No documentation update needed as it's compatible with the current docs.

Cyb3rWard0g
Cyb3rWard0g previously approved these changes Dec 4, 2025

@Cyb3rWard0g Cyb3rWard0g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaron2

yaron2 commented Dec 4, 2025

Copy link
Copy Markdown
Member

@CasperGN see conflict

@CasperGN

CasperGN commented Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

@yaron2 merge conflict fixed

@CasperGN CasperGN mentioned this pull request Dec 4, 2025
4 tasks
@yaron2
yaron2 merged commit 58198e2 into dapr:main Dec 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DurableAgent with multiple tool calls throws WARN on conflict updating state save for workflow_state

3 participants