feat: Introduce new overwrite flag to jobs#8701
Merged
dapr-bot merged 17 commits intoMay 23, 2025
Merged
Conversation
javier-aliaga
changed the title
javier-aliaga
changed the title
javier-aliaga
marked this pull request as ready for review
May 7, 2025 13:41
The new flags can be use to specify if the job can overwrite an existing one. The default value is `false` Signed-off-by: Javier Aliaga <[email protected]>
javier-aliaga
force-pushed
the
javi-jobs-create-if-not-exists
branch
from
May 9, 2025 11:15
ddab7ea to
1533137
Compare
javier-aliaga
changed the title
javier-aliaga
marked this pull request as draft
May 9, 2025 11:34
Signed-off-by: Javier Aliaga <[email protected]>
…storage Signed-off-by: Javier Aliaga <[email protected]>
javier-aliaga
commented
May 12, 2025
javier-aliaga
changed the title
javier-aliaga
marked this pull request as ready for review
May 12, 2025 17:34
JoshVanL
requested changes
May 13, 2025
Move overwrite tests to its own files Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
7 tasks
JoshVanL
requested changes
May 15, 2025
Comment on lines
+80
to
+81
| {"overwrite2", `{"schedule": "@daily", "repeats": 3, "due_time": "10s", "ttl": "11s"}`, http.StatusInternalServerError}, | ||
| {"overwrite2", `{"schedule": "@daily", "repeats": 3, "overwrite": false, "due_time": "10s", "ttl": "11s"}`, http.StatusInternalServerError}, |
Contributor
There was a problem hiding this comment.
I would expect a HTTP status Conflict here.
Contributor
Author
There was a problem hiding this comment.
Fixed. Probably this is somthing we want to do for all errors here ? I have checked all other errors and they are not respecting neither the grpc code or the http code
Signed-off-by: Javier Aliaga <[email protected]>
Convert grc error code to http error code on http requests for schedule jobs Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
JoshVanL
added
autoupdate
JoshVanL
requested changes
May 20, 2025
Co-authored-by: Josh van Leeuwen <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: Josh van Leeuwen <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
JoshVanL
previously approved these changes
May 20, 2025
7 tasks
cicoyle
reviewed
May 21, 2025
cicoyle
removed
the
automerge
cicoyle
requested changes
May 21, 2025
Better assertions Import ordering Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
cicoyle
reviewed
May 21, 2025
javier-aliaga
commented
May 21, 2025
cicoyle
approved these changes
May 21, 2025
cicoyle
added
the
automerge
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a new flag to specify if a job can overwrite an existing one with the same name.
The default value is
false. This changes the current behaviour as of now the job is overwriten by defaultActor Reminderscan be scheduled using the scheduler or state store as storage. In that case we will always overwrite jobs to be consistent with state store implementationPRs to follow:
Issue reference
Please reference the issue this PR will close: #8402
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: