Fix workflow engine starting when actor runtime is disabled#8492
Merged
Conversation
Signed-off-by: Cassandra Coyle <[email protected]>
elena-kolevska
left a comment
elena-kolevska
left a comment
Contributor
There was a problem hiding this comment.
lgtm, but seems like there's a related test failing
cicoyle
marked this pull request as draft
February 18, 2025 17:46
cicoyle
marked this pull request as ready for review
February 20, 2025 16:40
Contributor
Author
|
The IT test failures from last run were unrelated. Will verify with this next run again |
cicoyle
marked this pull request as draft
February 20, 2025 19:47
Signed-off-by: Cassandra Coyle <[email protected]>
cicoyle
marked this pull request as ready for review
February 20, 2025 21:03
Contributor
Author
|
The failing IT test is unrelated |
JoshVanL
requested changes
Feb 25, 2025
Contributor
Author
|
That e2e test has been flaky and is unrelated to the diff in this PR I believe |
JoshVanL
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow engine was starting even when the actor runtime was disabled due to empty placement addresses. This happened because we are checking the actor runtime status in wfengine here bc the
a.disabled.Load()in the actors pkg is not externally available to the wf engine pkg. This additional check ensures the workflow engine correctly detects when actors are disabled.I was running the
emtpyaddressIT test locally and noticed it running the wf engine by this log:workflow engine startedwhich does not occur anymore with this additional check.Apparently for backwards compatibility for the metadata API I could not proceed with the prior approach. Therefore, I switched to checking the actor engine which is essentially the same check thru a diff approach. This prevents wf from running if placement is disabled.