Actors: State store actor reminder drain wait group#8437
Merged
JoshVanL merged 7 commits intoJan 30, 2025
Conversation
Update state store actor reminder engine to lock evaluation during drain events, and give a 2 second grace period concurrently to all currently active reminders to complete before completing dissemination. Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
JoshVanL
changed the title
JoshVanL
marked this pull request as ready for review
January 29, 2025 20:21
cicoyle
approved these changes
Jan 29, 2025
cicoyle
left a comment
cicoyle
left a comment
Contributor
There was a problem hiding this comment.
I was close, but missing the wg. nice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add wait group which waits for state store reminder loops to exit before continuing from a placement dissemination reminder drain.
Ensure ticks are always recorded to ensure we don't miss app reminder executions, and result in double invocations during disemination events.
Fixed e2e actor reminder e2e test.