Workflows: CRUD API sync#8434
Merged
JoshVanL merged 6 commits intoJan 30, 2025
Merged
Conversation
Due to the update of remote push based Scheduler for implementing workflow commands, the existing (non-durabletask gRPC client) crud operations will not have the command actually execute before the call returns to the client. Update the workflow universal APIs to wait for the desired state change before returning the call to the client. Fixes e2e tests which expect universal API calls to be sync. Signed-off-by: joshvanl <[email protected]>
cicoyle
approved these changes
Jan 29, 2025
elena-kolevska
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the update of remote push based Scheduler for implementing workflow commands, the existing (non-durabletask gRPC client) crud operations will not have the command actually execute before the call returns to the client.
Update the workflow universal APIs to wait for the desired state change before returning the call to the client.
Fixes e2e tests which expect universal API calls to be sync.