Skip to content

Error Code Metrics Improved Testing+Recording#8345

Merged
yaron2 merged 23 commits into
dapr:release-1.15from
jake-engelberg:ecm-improvements-2
Jan 24, 2025
Merged

Error Code Metrics Improved Testing+Recording#8345
yaron2 merged 23 commits into
dapr:release-1.15from
jake-engelberg:ecm-improvements-2

Conversation

@jake-engelberg

@jake-engelberg jake-engelberg commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

Description

  • Binding + Service Invocation error codes were categorized incorrectly, this is fixed.
  • RecordErrorCodeEarly(), respondWithHTTPRawResponseAndRecordError(), respondWithDataAndRecordError() added to record missing codes in gRPC implementations of APIs where the HTTP implementation has the code, or bulk/special responses for http.
  • Integration testing for metrics is added to existing places where error codes were triggered.

Issue reference

Followup to: #8256
OG Proposal: dapr/proposals#67

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Comment thread pkg/api/grpc/grpc.go Outdated
Comment thread tests/integration/framework/process/daprd/daprd.go Outdated
Comment thread pkg/api/grpc/grpc.go Outdated
@elena-kolevska

Copy link
Copy Markdown
Contributor

Hey @jake-engelberg , ping me when I can re-review. I'll hold on updating the error codes in docs until this gets merged.

Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
@jake-engelberg
jake-engelberg marked this pull request as ready for review January 3, 2025 18:31
@jake-engelberg
jake-engelberg requested review from a team as code owners January 3, 2025 18:31
Comment thread pkg/api/grpc/grpc.go
Comment thread pkg/api/grpc/grpc.go Outdated
Comment thread pkg/diagnostics/errorcode_monitoring.go Outdated
Comment thread pkg/api/grpc/grpc_test.go Outdated
Comment thread pkg/messages/errorcodes/errorcodes.go Outdated
Comment thread tests/integration/framework/process/metrics/metrics.go
elena-kolevska
elena-kolevska previously approved these changes Jan 21, 2025

@elena-kolevska elena-kolevska left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on adding additional metrics check in the integration tests!

Signed-off-by: Jake Engelberg <[email protected]>
@yaron2
yaron2 merged commit 9e432a1 into dapr:release-1.15 Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants