Error Code Metrics Improved Testing+Recording#8345
Merged
Conversation
…error intgtest Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
elena-kolevska
suggested changes
Dec 11, 2024
5 tasks
Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
Contributor
|
Hey @jake-engelberg , ping me when I can re-review. I'll hold on updating the error codes in docs until this gets merged. |
jake-engelberg
force-pushed
the
ecm-improvements-2
branch
from
January 3, 2025 00:47
46f5f73 to
dfb086f
Compare
Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
jake-engelberg
force-pushed
the
ecm-improvements-2
branch
from
January 3, 2025 16:18
187068b to
f0cf25e
Compare
Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
jake-engelberg
force-pushed
the
ecm-improvements-2
branch
from
January 3, 2025 17:22
a1dc246 to
d086dd9
Compare
Signed-off-by: Jake Engelberg <[email protected]>
elena-kolevska
suggested changes
Jan 7, 2025
Co-authored-by: Elena Kolevska <[email protected]> Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
Signed-off-by: Jake Engelberg <[email protected]>
jake-engelberg
force-pushed
the
ecm-improvements-2
branch
from
January 21, 2025 16:49
7a1d601 to
e7939fe
Compare
elena-kolevska
previously approved these changes
Jan 21, 2025
elena-kolevska
left a comment
Contributor
There was a problem hiding this comment.
Great work on adding additional metrics check in the integration tests!
Signed-off-by: Jake Engelberg <[email protected]>
yaron2
approved these changes
Jan 22, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RecordErrorCodeEarly(),respondWithHTTPRawResponseAndRecordError(),respondWithDataAndRecordError()added to record missing codes in gRPC implementations of APIs where the HTTP implementation has the code, or bulk/special responses for http.Issue reference
Followup to: #8256
OG Proposal: dapr/proposals#67
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: