Fix flakiness on get metadata e2e.#4080
Conversation
Signed-off-by: Artur Souza <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4080 +/- ##
=======================================
Coverage 63.19% 63.19%
=======================================
Files 101 101
Lines 9654 9654
=======================================
Hits 6101 6101
Misses 3074 3074
Partials 479 479 Continue to review full report at Codecov.
|
|
/ok-to-test |
|
Found the available test cluster - dapr-aks-e2e-07 for linux. Please check the build status. |
| require.Greater(t, len(currentMetadata.Actors), 0) | ||
| require.Equal(t, "testactorfeatures", currentMetadata.Actors[0].Type) | ||
| require.Equal(t, "testactorfeatures", previousMetadata.Actors[0].Type) | ||
| require.Greater(t, currentMetadata.Actors[0].Count, previousMetadata.Actors[0].Count) |
There was a problem hiding this comment.
We just assert it is greater and not necessarily the exact count.
|
Found the available test cluster - dapr-aks-e2e-05 for windows. Please check the build status. |
|
End-to-end tests failed on windows. Please check the build logs |
|
Developers may not consider parallel issues, do we really need run tests in parallel? If so, we should better highlight those tests. |
The time to run tests increase a lot without parallelism. We need to keep this in mind when reviewing PRs. This is the only way to reduce time to run tests. IMO. |
|
Look at https://github.com/dapr/dapr/runs/4698628375?check_suite_focus=true, build and push containers spend ~50% time, if we do it only once before all e2e tests, we can reduce much time. |
|
Congrats! All end-to-end tests have passed on linux. Thanks for your contribution! |
Yes, that is right. We have kept the build of E2E apps in the pipeline because it is very common to have PRs that require changes to E2E test app to be merged together with the test code. I agree that we can expedite the build time too. |
* master: Saves 'describe' output of K8s resources for E2E tests. (dapr#4082) Fix flakiness on get metadata e2e. (dapr#4080) Return error instead of crashing when receiving grpc_proxy request on uninitialized daprd Fix actor reminder e2e tests + fixes to reminder partition (dapr#4021) Upgrading fasthttp to fix shutdown issue Fixed create timer duetime remove max graceful shutdown duration limit fix lint add more test case fix lint Make the grace period configurable Signed-off-by: Taction <[email protected]>
Signed-off-by: Artur Souza <[email protected]> Signed-off-by: x-shadow-man <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
4 participants
Fix flakiness on get metadata e2e when there are additional tests running in parallel that can influence the actor count.
Issue reference
Please reference the issue this PR will close: #N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: