feat: add config api by LaurenceLiZhixin · Pull Request #3606 · dapr/dapr

LaurenceLiZhixin · 2021-09-01T11:23:08Z

Description

Issue reference

Please reference the issue this PR will close: #2988

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Unit tests passing
End-to-end tests passing
Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

yaron2 · 2021-09-08T15:08:02Z

@LaurenceLiZhixin notice the checks are failing

dapr-bot · 2021-10-21T01:32:51Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

LaurenceLiZhixin · 2021-10-22T06:07:48Z

I updated this pr and It's able to be reviewed I think. @artursouza

codecov · 2021-10-27T01:57:56Z

Codecov Report

Merging #3606 (8e9bcec) into master (97d1e84) will decrease coverage by 0.43%.
The diff coverage is 21.69%.

@@            Coverage Diff             @@
##           master    #3606      +/-   ##
==========================================
- Coverage   62.93%   62.49%   -0.44%     
==========================================
  Files         100      101       +1     
  Lines        9421     9525     +104     
==========================================
+ Hits         5929     5953      +24     
- Misses       3026     3107      +81     
+ Partials      466      465       -1

Impacted Files	Coverage Δ
pkg/grpc/api.go	`54.03% <0.00%> (-5.11%)`	⬇️
pkg/runtime/options.go	`11.11% <0.00%> (-1.39%)`	⬇️
pkg/runtime/runtime.go	`63.98% <20.83%> (-0.98%)`	⬇️
pkg/components/configuration/registry.go	`100.00% <100.00%> (ø)`
pkg/actors/internal/placement.go	`89.11% <0.00%> (+1.55%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d1e84...8e9bcec. Read the comment docs.

LaurenceLiZhixin · 2021-10-27T03:50:40Z

The tests passed. @artursouza

daixiang0 · 2021-11-02T01:14:35Z

@LaurenceLiZhixin still fail.

LaurenceLiZhixin · 2021-11-02T02:52:04Z

@LaurenceLiZhixin still fail.

Could you please restart the e2e test again? I guess this problem is not my fault that caused it. And the previous commit can pass all tests.

daixiang0 · 2021-11-02T02:56:18Z

@LaurenceLiZhixin Please ensure resolve all comments.

LaurenceLiZhixin · 2021-11-02T03:39:19Z

@LaurenceLiZhixin Please ensure resolve all comments.

Done @daixiang0

yaron2 · 2021-11-03T00:20:27Z

Thanks @LaurenceLiZhixin resolve conflicts please.

yaron2

lgtm

seeflood · 2021-11-04T17:05:34Z

Cool!

artursouza

LGTM

LaurenceLiZhixin added 2 commits September 1, 2021 19:13

feat: add config api

ec3062c

fix: fix conflict

7b60a47

LaurenceLiZhixin requested review from a team as code owners September 1, 2021 11:23

LaurenceLiZhixin changed the title ~~feat: add config api~~ [WIP] feat: add config api Sep 1, 2021

LaurenceLiZhixin mentioned this pull request Sep 1, 2021

[Proposal] configuration api design #2988

Closed

artursouza self-assigned this Sep 1, 2021

msfussell mentioned this pull request Oct 20, 2021

[WIP] Ftr: configuration store docs dapr/docs#1860

Closed

6 tasks

dapr-bot added stale Issues and PRs without response and removed stale Issues and PRs without response labels Oct 21, 2021

LaurenceLiZhixin added 2 commits October 21, 2021 19:07

fix: update component contribute

ad567ed

fix: fixconflict

daec9aa

LaurenceLiZhixin force-pushed the config-api branch from 67d970c to daec9aa Compare October 21, 2021 11:24

LaurenceLiZhixin changed the title ~~[WIP] feat: add config api~~ feat: add config api Oct 22, 2021

fix: remove typo

ea0ecbf

artursouza suggested changes Oct 22, 2021

View reviewed changes

LaurenceLiZhixin added 2 commits October 25, 2021 10:57

fix: conflict

237715d

fix: conflict

0aa0a48

LaurenceLiZhixin force-pushed the config-api branch from a0c651b to 0aa0a48 Compare October 25, 2021 03:43

LaurenceLiZhixin and others added 5 commits October 25, 2021 11:48

fix: proto-gen

843f5f1

fix: ci diff check

413e966

Merge branch 'master' into config-api

800fbe6

fix: mod tidy

02a70b6

Merge branch 'master' into config-api

07d21e0

Merge branch 'master' into config-api

55c16e0

yaron2 added 2 commits October 27, 2021 11:46

Merge branch 'master' into config-api

28f6adb

Merge branch 'master' into config-api

aacc6d5

Merge branch 'master' of github.com:dapr/dapr into config-api

514b79f

LaurenceLiZhixin added 2 commits November 2, 2021 11:20

fix: change gRPC config-api version to alpha

d72b778

Merge remote-tracking branch 'origin/config-api' into config-api

4d20e92

fix: conflict

8e9bcec

yaron2 approved these changes Nov 4, 2021

View reviewed changes

yaron2 merged commit 0ba7933 into dapr:master Nov 4, 2021

artursouza reviewed Nov 4, 2021

View reviewed changes

seeflood mentioned this pull request Nov 5, 2021

Community tasks 新手任务计划 mosn/layotto#108

Open

seeflood mentioned this pull request Dec 1, 2021

Let Layotto support Dapr's Config API (alpha version) mosn/layotto#347

Closed

amulyavarote mentioned this pull request Jan 11, 2022

Add support for Configuration API (Subscribe Configuration API) dapr/python-sdk#334

Closed

wangxingyu000 mentioned this pull request Mar 23, 2022

“SOFA 星球”闯关计划 —— Layotto飞船 mosn/layotto#438

Closed

20 tasks

DeepanshuA mentioned this pull request Dec 30, 2022

Add Configuration Store SDK Spec dapr/sig-sdk-spec#23

Merged

This was referenced Feb 27, 2026

🌱 CNCF mission generation 2026-02-27 kubestellar/console-kb#6

Closed

🌱 CNCF mission generation 2026-02-27 kubestellar/console-kb#11

Merged

Uh oh!

Conversation

LaurenceLiZhixin commented Sep 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue reference

Checklist

Uh oh!

yaron2 commented Sep 8, 2021

Uh oh!

dapr-bot commented Oct 21, 2021

Uh oh!

LaurenceLiZhixin commented Oct 22, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Oct 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LaurenceLiZhixin commented Oct 27, 2021

Uh oh!

daixiang0 commented Nov 2, 2021

Uh oh!

LaurenceLiZhixin commented Nov 2, 2021

Uh oh!

daixiang0 commented Nov 2, 2021

Uh oh!

LaurenceLiZhixin commented Nov 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yaron2 commented Nov 3, 2021

Uh oh!

yaron2 left a comment

Choose a reason for hiding this comment

Uh oh!

seeflood commented Nov 4, 2021

Uh oh!

artursouza left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LaurenceLiZhixin commented Sep 1, 2021 •

edited

Loading

codecov Bot commented Oct 27, 2021 •

edited

Loading

LaurenceLiZhixin commented Nov 2, 2021 •

edited

Loading