Skip to content

components: make version field required#2714

Merged
artursouza merged 2 commits into
dapr:masterfrom
yaron2:versionreq-1
Jan 25, 2021
Merged

components: make version field required#2714
artursouza merged 2 commits into
dapr:masterfrom
yaron2:versionreq-1

Conversation

@yaron2

@yaron2 yaron2 commented Jan 25, 2021

Copy link
Copy Markdown
Member

Closes #2260

@yaron2
yaron2 requested a review from artursouza January 25, 2021 22:07
@codecov

codecov Bot commented Jan 25, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2714 (fc47653) into master (f4327d9) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2714      +/-   ##
==========================================
+ Coverage   57.96%   58.01%   +0.05%     
==========================================
  Files          82       82              
  Lines        7367     7367              
==========================================
+ Hits         4270     4274       +4     
+ Misses       2803     2799       -4     
  Partials      294      294              
Impacted Files Coverage Δ
pkg/placement/membership.go 53.90% <0.00%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4327d9...673d73c. Read the comment docs.

@mukundansundar

Copy link
Copy Markdown
Contributor

potentially multiple docs and all quickstarts need to be updated with the version field in component file.
Should CLI also be updated?

@artursouza
artursouza merged commit 5a15b3e into dapr:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make required the version field on Component YAML

3 participants