Skip to content

Use Aborted error code for ETag mismatch#2648

Merged
yaron2 merged 1 commit into
dapr:masterfrom
rynowak:rynowak/use-aborted
Jan 12, 2021
Merged

Use Aborted error code for ETag mismatch#2648
yaron2 merged 1 commit into
dapr:masterfrom
rynowak:rynowak/use-aborted

Conversation

@rynowak

@rynowak rynowak commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

Description

I started a discussion after #2647 was
merged because I think there's a better fit for an ETag mismatch than
AlreadyExists.

The gRPC docs have specific guidance that Aborted is the best status for
'when a client-specified test-and-set fails', which is this case. link

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Related to #2619

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Related to dapr#2619

I started a discussion after dapr#2647 was
merged because I think there's a better fit for an ETag mismatch than
AlreadyExists.

The gRPC docs have specific guidance that Aborted is the best status for
'when a client-specified test-and-set fails', which is this case.
@rynowak
rynowak requested review from artursouza and yaron2 January 12, 2021 00:16

@yaron2 yaron2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov

codecov Bot commented Jan 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2648 (3598361) into master (929e9df) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2648      +/-   ##
==========================================
+ Coverage   58.10%   58.12%   +0.01%     
==========================================
  Files          82       82              
  Lines        7288     7288              
==========================================
+ Hits         4235     4236       +1     
+ Misses       2760     2758       -2     
- Partials      293      294       +1     
Impacted Files Coverage Δ
pkg/grpc/api.go 62.79% <100.00%> (ø)
pkg/actors/internal/placement.go 84.61% <0.00%> (-1.93%) ⬇️
pkg/placement/membership.go 53.90% <0.00%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929e9df...2bbf277. Read the comment docs.

@yaron2
yaron2 merged commit 4678e47 into dapr:master Jan 12, 2021
@rynowak
rynowak deleted the rynowak/use-aborted branch January 12, 2021 00:57
@artursouza

Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants