Skip to content

add etag error distinction for state operations#2647

Merged
yaron2 merged 4 commits into
dapr:masterfrom
yaron2:etagerr-1
Jan 11, 2021
Merged

add etag error distinction for state operations#2647
yaron2 merged 4 commits into
dapr:masterfrom
yaron2:etagerr-1

Conversation

@yaron2

@yaron2 yaron2 commented Jan 11, 2021

Copy link
Copy Markdown
Member

Fixes #2619

@yaron2
yaron2 requested a review from artursouza January 11, 2021 23:10
@codecov

codecov Bot commented Jan 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2647 (d65d4c0) into master (fdace7d) will increase coverage by 0.21%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2647      +/-   ##
==========================================
+ Coverage   57.94%   58.16%   +0.21%     
==========================================
  Files          82       82              
  Lines        7258     7288      +30     
==========================================
+ Hits         4206     4239      +33     
+ Misses       2758     2756       -2     
+ Partials      294      293       -1
Impacted Files Coverage Δ
pkg/grpc/api.go 62.79% <90.90%> (+0.43%) ⬆️
pkg/http/api.go 86.42% <96.29%> (+0.23%) ⬆️
pkg/placement/membership.go 53.90% <0.00%> (+1.41%) ⬆️
pkg/actors/internal/placement.go 86.53% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf19da2...b54187d. Read the comment docs.

@yaron2
yaron2 merged commit 929e9df into dapr:master Jan 11, 2021
rynowak added a commit to rynowak/dapr that referenced this pull request Jan 12, 2021
@rynowak
Use Aborted error code for ETag mismatch
2bbf277 
Related to dapr#2619

I started a discussion after dapr#2647 was
merged because I think there's a better fit for an ETag mismatch than
AlreadyExists.

The gRPC docs have specific guidance that Aborted is the best status for
'when a client-specified test-and-set fails', which is this case.
@rynowak rynowak mentioned this pull request Jan 12, 2021
Merged
7 tasks
yaron2 pushed a commit that referenced this pull request Jan 12, 2021
@rynowak
Use Aborted error code for ETag mismatch (#2648)
4678e47 
Related to #2619

I started a discussion after #2647 was
merged because I think there's a better fit for an ETag mismatch than
AlreadyExists.

The gRPC docs have specific guidance that Aborted is the best status for
'when a client-specified test-and-set fails', which is this case.
This was referenced Jan 13, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@artursouza artursouza artursouza approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Return HTTP 409 Conflict when ETag doesn't match

2 participants

@yaron2 @artursouza