Skip to content

Implementing BulkGetSecret#2419

Merged
yaron2 merged 1 commit into
dapr:masterfrom
cmendible:issue-2168
Dec 14, 2020
Merged

Implementing BulkGetSecret#2419
yaron2 merged 1 commit into
dapr:masterfrom
cmendible:issue-2168

Conversation

@cmendible

@cmendible cmendible commented Nov 10, 2020

Copy link
Copy Markdown
Member

Description

since dapr/components-contrib#309 was closed this PR adds the BulkGetSecret api to dapr.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #2168

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@codecov

codecov Bot commented Nov 10, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2419 (0b41417) into master (cb60f8f) will decrease coverage by 0.20%.
The diff coverage is 33.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2419      +/-   ##
==========================================
- Coverage   57.56%   57.35%   -0.21%     
==========================================
  Files          81       81              
  Lines        7115     7174      +59     
==========================================
+ Hits         4096     4115      +19     
- Misses       2734     2766      +32     
- Partials      285      293       +8
Impacted Files Coverage Δ
pkg/grpc/api.go 60.58% <33.33%> (-1.35%) ⬇️
pkg/http/api.go 86.05% <34.28%> (-2.41%) ⬇️
pkg/placement/membership.go 51.06% <0.00%> (-2.84%) ⬇️
pkg/actors/internal/placement.go 86.53% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb60f8f...0b41417. Read the comment docs.

@cmendible
cmendible force-pushed the issue-2168 branch 3 times, most recently from 2973056 to 4492778 Compare November 13, 2020 09:42
yaron2
yaron2 reviewed Nov 13, 2020
View reviewed changes
Comment thread dapr/proto/runtime/v1/dapr.proto
@cmendible
cmendible force-pushed the issue-2168 branch 2 times, most recently from 2d753ec to 4a2c8d8 Compare November 25, 2020 08:01
@yaron2

yaron2 commented Dec 5, 2020

Copy link
Copy Markdown
Member

@cmendible can you resolve the conflicts please?

@cmendible
cmendible force-pushed the issue-2168 branch 2 times, most recently from fc5d5e0 to 34e09cc Compare December 8, 2020 16:37
@yaron2

yaron2 commented Dec 14, 2020

Copy link
Copy Markdown
Member

@cmendible can you please resolve the conflict? we can then proceed to merge.

yaron2
yaron2 previously approved these changes Dec 14, 2020
View reviewed changes

@yaron2 yaron2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cmendible cmendible changed the title [WIP] Implementing BulkGetSecret Implementing BulkGetSecret Dec 14, 2020
@cmendible

cmendible commented Dec 14, 2020

Copy link
Copy Markdown
Member Author

@cmendible can you please resolve the conflict? we can then proceed to merge.

@yaron2 Conflicts resolved but now codecov is failing....

@yaron2

yaron2 commented Dec 14, 2020

Copy link
Copy Markdown
Member

@cmendible can you please resolve the conflict? we can then proceed to merge.

@yaron2 Conflicts resolved but now codecov is failing....

Let me worry about codecov :)

Do we have a docs PR for this change? Updating the API reference and the Secrets section

@yaron2
yaron2 merged commit f049c8c into dapr:master Dec 14, 2020
@cmendible cmendible mentioned this pull request Dec 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaron2 yaron2 yaron2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get all secrets from secrets API

2 participants

@cmendible @yaron2