Fix get bulk secret for hashicorp vault.#632
Conversation
|
I was surprised when I saw that:
Let's all take a moment to thank Java SDK's ITs for saving our a** one more time. |
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
==========================================
- Coverage 30.79% 30.78% -0.01%
==========================================
Files 87 87
Lines 7320 7322 +2
==========================================
Hits 2254 2254
- Misses 4830 4832 +2
Partials 236 236
Continue to review full report at Codecov.
|
|
|
||
| // Create list secrets url | ||
| vaultSecretsPathAddr := fmt.Sprintf("%s/v1/secret/data/%s", v.vaultAddress, v.vaultKVPrefix) | ||
| vaultSecretsPathAddr := fmt.Sprintf("%s/v1/secret/metadata/%s", v.vaultAddress, v.vaultKVPrefix) |
There was a problem hiding this comment.
why did this change? there's another occurance for this in getSecret
There was a problem hiding this comment.
Mukundan made the same question. This URL here is used for the LIST API, which (as per hashicorp documentation) is a metadata operation.
In the end, I actually ran this as part of my ITs in Java SDK the old way does not work at all.
3 participants
Description
Fix get bulk secret for hashicorp vault.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: None
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: