Adds Global TTL Configuration for DynamoDB State Store#4055
Closed
ZeynelKoca wants to merge 3 commits into
Closed
Conversation
|
Would be nice when the different statestores (Redis and Dynamo) behave in a similar way. |
Contributor
|
There will be a slight delay in reviewing the DynamoDB-related PRs. We need to address the missing/disabled tests first, which are being tracked in issue #4047. Thanks for your patience! |
sicoyle
reviewed
Oct 21, 2025
Author
|
@sicoyle Ready for another review round |
sicoyle
reviewed
Oct 27, 2025
sicoyle
left a comment
sicoyle
left a comment
Contributor
There was a problem hiding this comment.
one last comment and then this LGTM - thank you!
Author
Fixed. Also updated the docs PR with the same description |
ZeynelKoca
force-pushed
the
dynamo-global-ttl
branch
from
October 30, 2025 14:11
b51bf00 to
e01dcdf
Compare
sicoyle
previously approved these changes
Oct 30, 2025
Contributor
|
@ZeynelKoca pls see the build failures and ping when you're ready and I can retrigger 🙏 |
ZeynelKoca
force-pushed
the
dynamo-global-ttl
branch
from
October 30, 2025 14:55
50d65a1 to
e01dcdf
Compare
Author
|
@sicoyle Fixed a stupid rebase mistake. Try again? |
ZeynelKoca
force-pushed
the
dynamo-global-ttl
branch
from
November 5, 2025 09:05
e8b1d9d to
8e8f446
Compare
ZeynelKoca
force-pushed
the
dynamo-global-ttl
branch
from
November 18, 2025 09:53
8e8f446 to
494a6b9
Compare
Author
|
@sicoyle Can the pipeline run get an approval? |
sicoyle
previously approved these changes
Nov 18, 2025
Author
|
@sicoyle Fixed the formatting 🙏 |
Author
|
@sicoyle I think a re-run is needed? Pipelines failed due to being unable to checkout the repo |
Contributor
rerunning, lets see. I know github has been having quite a few issues recently |
ZeynelKoca
commented
Nov 20, 2025
Author
Fixed another formatting issue 🙏 |
ZeynelKoca
force-pushed
the
dynamo-global-ttl
branch
2 times, most recently
from
November 21, 2025 08:49
6b25c88 to
3eb43a9
Compare
ZeynelKoca
force-pushed
the
dynamo-global-ttl
branch
from
December 4, 2025 14:11
3eb43a9 to
ced1c9e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@mikeee Implemented your suggestion and 2 small (and valid) ones from copilot |
mikeee
approved these changes
Apr 3, 2026
mikeee
left a comment
mikeee
left a comment
Member
There was a problem hiding this comment.
lgtm, cheers for keeping on top of this.
Member
|
/ok-to-test |
Collaborator
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 07f3560 |
Collaborator
Components conformance testCommit ref: 07f3560 ❌ Some conformance tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Collaborator
Components certification testCommit ref: 07f3560 ❌ Some certification tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Author
|
@mikeee can you rerun the workflows. Lots of tests failed due to failed secret setup |
mikeee
requested changes
Apr 4, 2026
Signed-off-by: Zeynel Koca <[email protected]>
ZeynelKoca
force-pushed
the
dynamo-global-ttl
branch
from
April 4, 2026 23:14
07f3560 to
f53336d
Compare
Author
Good catch, updated the cert test. TTL=-1 now means "no expiration" so the test asserts the item persists without a ttlExpireTime |
Member
|
@mikeee we good to go here? |
Member
|
/ok-to-test |
Collaborator
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 3d4b873 |
Collaborator
Components certification testCommit ref: 3d4b873 ❌ Some certification tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Collaborator
Components conformance testCommit ref: 3d4b873 ❌ Some conformance tests failedThese tests failed:
Additionally, some tests did not report a status:
|
Author
Collaborator
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Collaborator
|
This pull request has been automatically closed because it was marked stale with no further activity for 7 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a way to globally configure the state TTL for dynamo (inspired by #1059).
The defined default TTL will only be used if the state request does not explicitly specify a TTL itself.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: