Skip to content

Add coherence state store component - updated#3838

Merged
yaron2 merged 7 commits into
dapr:mainfrom
tmiddlet2666:coherence-v2
Jun 26, 2025
Merged

Add coherence state store component - updated#3838
yaron2 merged 7 commits into
dapr:mainfrom
tmiddlet2666:coherence-v2

Conversation

@tmiddlet2666

@tmiddlet2666 tmiddlet2666 commented Jun 5, 2025

Copy link
Copy Markdown

Description

Added a new implementation for a Coherence state store component.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@tmiddlet2666
tmiddlet2666 requested review from a team as code owners June 5, 2025 03:40
@tmiddlet2666

tmiddlet2666 commented Jun 5, 2025

Copy link
Copy Markdown
Author

Hi @JoshVanL @daixiang0
Creating this new PR to replace the old one which i will close.
There were too many conflicts in my manual merge

@tmiddlet2666 tmiddlet2666 mentioned this pull request Jun 5, 2025
Closed
3 tasks
@tmiddlet2666

tmiddlet2666 commented Jun 10, 2025

Copy link
Copy Markdown
Author

Hi @JoshVanL @daixiang0
Anything more i need to do here, thanks?

nelson-parente
nelson-parente reviewed Jun 16, 2025
View reviewed changes

@nelson-parente nelson-parente left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm! added some nits

Comment thread state/coherence/coherence.go Outdated
Comment thread state/coherence/coherence.go Outdated
Comment thread state/coherence/coherence.go Outdated
Tim Middleton
Address review comments
32ce43c 
Signed-off-by: Tim Middleton <[email protected]>
@tmiddlet2666

tmiddlet2666 commented Jun 17, 2025

Copy link
Copy Markdown
Author

Thanks @nelson-parente
I have pushed updated code to address review comments.

nelson-parente
nelson-parente previously approved these changes Jun 17, 2025
View reviewed changes
@tmiddlet2666

tmiddlet2666 commented Jun 20, 2025

Copy link
Copy Markdown
Author

@JoshVanL @daixiang0
Please let me know if any more changes are required now @nelson-parente has approved
Thanks

@tmiddlet2666

tmiddlet2666 commented Jun 24, 2025

Copy link
Copy Markdown
Author

Any more changes required here? Can we can this approved and merged please?
Thanks

@cicoyle cicoyle added the documentation required This issue needs documentation label Jun 25, 2025
cicoyle
cicoyle reviewed Jun 25, 2025
View reviewed changes
Comment thread tests/certification/state/coherence/README.md Outdated
cicoyle
cicoyle previously approved these changes Jun 25, 2025
View reviewed changes

@cicoyle cicoyle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo nit, but otherwise lgtm

Tim Middleton @cicoyle
Update tests/certification/state/coherence/README.md
664bb0d 
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Tim Middleton <[email protected]>
@tmiddlet2666
tmiddlet2666 dismissed stale reviews from cicoyle and nelson-parente via 664bb0d June 26, 2025 00:52
@yaron2
yaron2 merged commit 73da167 into dapr:main Jun 26, 2025
90 of 91 checks passed
@tmiddlet2666
tmiddlet2666 deleted the coherence-v2 branch June 26, 2025 04:46
@yaron2

yaron2 commented Jun 26, 2025

Copy link
Copy Markdown
Member

@tmiddlet2666 Please follow up with a docs PR to add this to our docs. See an example here: dapr/docs#4691

@tmiddlet2666

tmiddlet2666 commented Jun 26, 2025

Copy link
Copy Markdown
Author

@tmiddlet2666 Please follow up with a docs PR to add this to our docs. See an example here: dapr/docs#4691

Thanks @yaron2
I have created a doc issue for my previous PR dapr/docs#4661
Will look at the above example.
Thanks

@tmiddlet2666 tmiddlet2666 mentioned this pull request Jun 27, 2025
Closed
7 tasks
mikeee pushed a commit to mikeee/dapr_components-contrib that referenced this pull request Jun 27, 2025
Tim Middleton @nelson-parente
@cicoyle @mikeee
Add coherence state store component - updated (dapr#3838)
ada2d55 
Signed-off-by: Tim Middleton <[email protected]>
Co-authored-by: Nelson Parente <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
@tmiddlet2666 tmiddlet2666 mentioned this pull request Jul 3, 2025
Merged
7 tasks
sicoyle pushed a commit to sicoyle/components-contrib that referenced this pull request Jul 7, 2025
Tim Middleton @nelson-parente @cicoyle
Add coherence state store component - updated (dapr#3838)
71425b9 
Signed-off-by: Tim Middleton <[email protected]>
Co-authored-by: Nelson Parente <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
passuied pushed a commit to passuied/components-contrib that referenced this pull request Feb 14, 2026
Tim Middleton @nelson-parente
@cicoyle @passuied
Add coherence state store component - updated (dapr#3838)
33c9383 
Signed-off-by: Tim Middleton <[email protected]>
Co-authored-by: Nelson Parente <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaron2 yaron2 yaron2 approved these changes
@nelson-parente nelson-parente nelson-parente left review comments
@cicoyle cicoyle cicoyle left review comments

Assignees

No one assigned

Labels

documentation required This issue needs documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmiddlet2666 @yaron2 @nelson-parente @cicoyle