Skip to content

feat: support subscribeMode field on pulsar#3831

Merged
yaron2 merged 15 commits into
dapr:mainfrom
ericsyh:pulsar-subscription-mode
Jun 26, 2025
Merged

feat: support subscribeMode field on pulsar#3831
yaron2 merged 15 commits into
dapr:mainfrom
ericsyh:pulsar-subscription-mode

Conversation

@ericsyh

@ericsyh ericsyh commented May 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #3832

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@ericsyh
ericsyh requested review from a team as code owners May 22, 2025 15:37
@ericsyh ericsyh mentioned this pull request May 23, 2025
Merged
7 tasks
@msfussell

msfussell commented May 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@ericsyh - Is there an issue number for this PR?

@ericsyh

ericsyh commented May 24, 2025

Copy link
Copy Markdown
Contributor Author

@ericsyh - Is there an issue number for this PR?

@msfussell sorry i missed the issue create before, just created a new issue of #3832 and linked on this PR.

nelson-parente
nelson-parente previously approved these changes May 26, 2025
View reviewed changes

@nelson-parente nelson-parente left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikeee
mikeee reviewed May 28, 2025
View reviewed changes

@mikeee mikeee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, just a few nits

Comment thread pubsub/pulsar/pulsar.go
Comment thread pubsub/pulsar/pulsar.go
@ericsyh @mikeee
Update pubsub/pulsar/pulsar.go
ae59847 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Eric Shen <[email protected]>
@ericsyh

ericsyh commented Jun 1, 2025

Copy link
Copy Markdown
Contributor Author

@nelson-parente @mikeee Could you help review again? cc @yaron2 @JoshVanL help review

mikeee
mikeee previously approved these changes Jun 11, 2025
View reviewed changes

@mikeee mikeee left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - running the tests now

@mikeee

mikeee commented Jun 11, 2025

Copy link
Copy Markdown
Member

Looks like a minor linter issue popped up if you could please address it :)

Eric Shen
fix lint
14f449d 
Signed-off-by: Eric Shen <[email protected]>
@ericsyh

ericsyh commented Jun 11, 2025

Copy link
Copy Markdown
Contributor Author

Looks like a minor linter issue popped up if you could please address it :)

@mikeee I just fixed the lint in the 14f449d, now it should be fine.

@ericsyh

ericsyh commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

@nelson-parente @msfussell PTAL the updated PR thx.

@nelson-parente

nelson-parente commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

@yaron2 I think this is good to merge

@yaron2
yaron2 added this pull request to the merge queue Jun 13, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 13, 2025
@ericsyh

ericsyh commented Jun 14, 2025

Copy link
Copy Markdown
Contributor Author

The lint and several comformance check fail in the merge-quege CI was not caused by my changes...

@ericsyh

ericsyh commented Jun 20, 2025

Copy link
Copy Markdown
Contributor Author

@yaron2 Hi Yaron, the merge queue was failed but it looks not caused by this PR, anything need change from this PR?

[/home/runner/work/components-contrib/components-contrib] ...
  common/authentication/aws/x509.go:162:14       staticcheck  SA1019: spiffecontext.From is deprecated: use FromX509 instead. From retrieves the x509 SVID source from the context. 
  common/authentication/aws/x509_test.go:120:10  staticcheck  SA1019: spiffecontext.With is deprecated: use WithX509 instead. With adds the x509 SVID source from the SPIFFE object to the context. 
  middleware/http/opa/middleware.go:32:2         staticcheck  SA1019: "github.com/open-policy-agent/opa/rego" is deprecated: This package is intended for older projects transitioning from OPA v0.x and will remain for the lifetime of OPA v1.x, but its use is not recommended. For newer features and behaviours, such as defaulting to the Rego v1 syntax, use the corresponding components in the [github.com/open-policy-agent/opa/v1] package instead. See https://www.openpolicyagent.org/docs/latest/v0-compatibility/ for more information.

@mikeee mikeee added the autoupdate automatically keeps PR up to date against master label Jun 24, 2025
@yaron2
yaron2 merged commit f1e67a0 into dapr:main Jun 26, 2025
90 checks passed
mikeee added a commit to mikeee/dapr_components-contrib that referenced this pull request Jun 27, 2025
@ericsyh @mikeee
@daixiang0 @nelson-parente Eric Shen @yaron2
feat: support subscribeMode field on pulsar (dapr#3831)
189fddd 
Signed-off-by: Eric Shen <[email protected]>
Signed-off-by: Eric Shen <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Co-authored-by: Loong Dai <[email protected]>
Co-authored-by: Nelson Parente <[email protected]>
Co-authored-by: Eric Shen <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
@ericsyh
ericsyh deleted the pulsar-subscription-mode branch June 29, 2025 12:27
sicoyle pushed a commit to sicoyle/components-contrib that referenced this pull request Jul 7, 2025
@ericsyh @mikeee
@daixiang0 @nelson-parente Eric Shen @yaron2
feat: support subscribeMode field on pulsar (dapr#3831)
87fd9ec 
Signed-off-by: Eric Shen <[email protected]>
Signed-off-by: Eric Shen <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Co-authored-by: Loong Dai <[email protected]>
Co-authored-by: Nelson Parente <[email protected]>
Co-authored-by: Eric Shen <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
passuied pushed a commit to passuied/components-contrib that referenced this pull request Feb 14, 2026
@ericsyh @mikeee
@daixiang0 @nelson-parente Eric Shen @yaron2 @passuied
feat: support subscribeMode field on pulsar (dapr#3831)
f8c115b 
Signed-off-by: Eric Shen <[email protected]>
Signed-off-by: Eric Shen <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Co-authored-by: Loong Dai <[email protected]>
Co-authored-by: Nelson Parente <[email protected]>
Co-authored-by: Eric Shen <[email protected]>
Co-authored-by: Yaron Schneider <[email protected]>
@javier-aliaga javier-aliaga mentioned this pull request Mar 30, 2026
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaron2 yaron2 yaron2 approved these changes
@mikeee mikeee mikeee approved these changes
@nelson-parente nelson-parente nelson-parente approved these changes

Assignees

No one assigned

Labels

autoupdate automatically keeps PR up to date against master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feat](pulsar): support the subscription mode in PubSub Pulsar fields.

6 participants

@ericsyh @msfussell @mikeee @nelson-parente @yaron2 @daixiang0