GCP Storage Bucket binding: Bulk file transfer#3811
Merged
Conversation
Signed-off-by: nelson.parente <[email protected]>
nelson-parente
changed the title
nelson-parente
changed the title
antontroshin
reviewed
May 7, 2025
Signed-off-by: nelson.parente <[email protected]>
nelson-parente
marked this pull request as ready for review
May 8, 2025 10:28
Signed-off-by: nelson.parente <[email protected]>
nelson-parente
force-pushed
the
feat/gcp-bulk-file-transfer
branch
from
May 9, 2025 10:50
cc80115 to
b3d2ad1
Compare
Member
|
@nelson-parente linter is failing |
Signed-off-by: nelson.parente <[email protected]>
Signed-off-by: nelson.parente <[email protected]>
JoshVanL
requested changes
May 22, 2025
Comment on lines
+491
to
+497
| close(errCh) | ||
|
|
||
| for err := range errCh { | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
All errors should be collected. Not return just one.
Contributor
Author
There was a problem hiding this comment.
fixed! please check if its okay with multierr
Comment on lines
+483
to
+486
| if err := os.WriteFile(destPath, data, 0o644); err != nil { | ||
| errCh <- err | ||
| return | ||
| } |
Contributor
There was a problem hiding this comment.
This data should be returned, no written to a file, no? How is the data useful if written to the daprd filesystem.
Contributor
Author
There was a problem hiding this comment.
I got a bit confused with the ask in the issue.. As @JoshVanL points out this would write the files to daprd filesystem and not the app filesystem.
Refactored to return all objects data PTAL
Signed-off-by: nelson.parente <[email protected]>
Signed-off-by: nelson.parente <[email protected]>
Signed-off-by: nelson.parente <[email protected]>
nelson-parente
force-pushed
the
feat/gcp-bulk-file-transfer
branch
from
May 22, 2025 13:39
ed46fd4 to
9a4773b
Compare
yaron2
approved these changes
May 22, 2025
This was referenced May 22, 2025
passuied
pushed a commit
to passuied/components-contrib
that referenced
this pull request
Feb 14, 2026
Signed-off-by: nelson.parente <[email protected]> Co-authored-by: Yaron Schneider <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds bulk get with parallel file downloads.
docs PR: TODO
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #3655
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: