fix get aws creds from environment#3617
Merged
Merged
Conversation
Signed-off-by: Fabian Martinez <[email protected]>
JoshVanL
approved these changes
Nov 28, 2024
elena-kolevska
previously approved these changes
Nov 28, 2024
Signed-off-by: Fabian Martinez <[email protected]>
Contributor
Author
|
ready again @elena-kolevska |
yaron2
approved these changes
Nov 28, 2024
Contributor
|
@holopin-bot @famarting Thank you Fabian! |
|
Congratulations @famarting, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm4879nr021760cjm9hpdz0b1 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
This was referenced Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes a bug introduced here https://github.com/dapr/components-contrib/pull/3591/files#diff-017233cbc5865ed02ab3eacc4bc99b36ced96fcaf3420176e41d414444e41bc9
previously it was possible to get an aws session without providing access key and secret key, and we would pick the credentials from the environment. But since that PR, specifically because of this
and the later check
that would always think that access key and secret key are available, despite of them having a value or not
this can cause this error from aws
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: