feat(postgres): add iam roles anywhere auth profile#3604
Conversation
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 0e4401c |
Components conformance testCommit ref: 0e4401c ❌ Some conformance tests failedThese tests failed:
|
Components certification testCommit ref: 0e4401c ❌ Some certification tests failedThese tests failed:
|
| func (a *StaticAuth) getDatabaseToken(ctx context.Context, poolConfig *pgxpool.Config) (string, error) { | ||
| dbEndpoint := poolConfig.ConnConfig.Host + ":" + strconv.Itoa(int(poolConfig.ConnConfig.Port)) | ||
| switch { | ||
| case a.accessKey != nil && a.secretKey != nil: |
There was a problem hiding this comment.
rather than this I would do a simple if statement, much simpler to read
|
so this PR is missing the assume role auth profile, right? |
Pls give me a sec on this PR bc I do need to make tweaks, but doing the kafka PR first. |
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
This PR includes the ability to assume a role in the auth profile |
Signed-off-by: Samantha Coyle <[email protected]>
|
latest metadata for postgres components aws auth profiles |
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
|
/ok-to-test |
Components conformance testCommit ref: faf743b ❌ Some conformance tests failedThese tests failed:
|
Components certification testCommit ref: faf743b ❌ Some certification tests failedThese tests failed:
|
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: faf743b |
|
this is ready pls. Conformance/certification test failures are unrelated |
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: faf743b |
Components certification testCommit ref: faf743b ❌ Some certification tests failedThese tests failed:
|
Components conformance testCommit ref: faf743b ❌ Some conformance tests failedThese tests failed:
|
Signed-off-by: Samantha Coyle <[email protected]> Co-authored-by: Yaron Schneider <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> # Conflicts: # .build-tools/pkg/metadataschema/builtin-authentication-profiles.go # bindings/kafka/metadata.yaml # common/authentication/aws/static.go # common/authentication/aws/x509.go # common/authentication/postgresql/metadata.go # pubsub/kafka/metadata.yaml
Signed-off-by: Samantha Coyle <[email protected]> Co-authored-by: Yaron Schneider <[email protected]>
Description
Add IAM Roles Anywhere auth profile to PostgreSQL components.
I saw where we've had fields like
awsAccessKeyandawsSecretKeyfields specific to postgres. However, in the AWS built in profiles for authentication we haveaccessKeyandsecretKey. I've moved things to where we have some TODO comments to remove those aws prefixed fields in Dapr 1.17; however, to not break existing users, we cannot just remove these additional fields. Due to this, I had to manually manipulate the metadata bundle even further unfortunately. This is something we should never do. However, again in the case of the auth profile titled"AWS: Access Key ID and Secret Access Key"I am forced to update the manipulations further to make the normally requiredaccessKeyandsecretKeyfields as non-required as we make a transition in the next two releases to the normalized AWS auth profile fields without theawsprefix.AWS Auth profiles with these changes:
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: